-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify that built-in presets only store values for nodes with @mode bi
#760
Comments
regarding this issue, this has to be a configuration option because there are definitely users of ossia-max who rely on not only bi parameters being saved |
I'm in favour of that. How should we handle it? A couple possibilities:
(This is assuming we'll never want to save get values, which might be controversial)
This seems more flexible and potentially less confusing. From the many discussions of whether GET nodes should be savable ( e.g. #504 (comment) ), it seems like it's good to leave this up to users. |
I assume that a device-wide configuration is not enough, and that this needs to be set per-parameter ? (with potentially the defaults being set in the device) |
@evanmtp any chance you could send me a quick Max patch which I could use for testing the feature ? ideally something with a device, a few parameters in various modes and the objects needed for saving / reloading presets so that I can test that it works (e.g. with the @saveget things already set, even if the attribute is not there yet) The reason is that I don't have a Max license so I cannot save patches... which makes testing a fairly frustrating experience |
How's this?
I don't remember if we discussed this, but is the idea that |
hum, there's something I don't understand - as I can see in the code, as of today, all the json and non-json preset saving already has
must investigate deeper... |
and that's been the case since early 2021 (thanks @avilleret !): 6a928d1 |
this is even more bewildering to me, I added tests to check and can still not see the offending nodes in the presets.. a46ec8b#diff-b4761634b8d777aba2da2212388b35a10843a986f0b6efd6ea176a9e2d1bc09cR281 |
I think this can be closed now - please see my comment in https://github.com/ossia/libossia/issues/764#issuecomment-1065940288. Thank you! |
No description provided.
The text was updated successfully, but these errors were encountered: