Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that built-in presets only store values for nodes with @mode bi #760

Closed
jcelerier opened this issue Feb 18, 2022 · 9 comments
Closed
Assignees

Comments

@jcelerier
Copy link
Member

No description provided.

@jcelerier
Copy link
Member Author

regarding this issue, this has to be a configuration option because there are definitely users of ossia-max who rely on not only bi parameters being saved

@evanmtp
Copy link
Contributor

evanmtp commented Feb 19, 2022

I'm in favour of that. How should we handle it? A couple possibilities:

  1. a single attribute that sets the "save mode," with a few options:
  • 0: save all values
  • 1: save only set and bi values
  • 2: save only bi values

(This is assuming we'll never want to save get values, which might be controversial)

  1. individual attributes for each parameter type:
  • saveget: 0 or 1 (default = 1)
  • saveset: 0 or 1 (default = 1)
  • savebi: 0 or 1 (default = 1)

This seems more flexible and potentially less confusing. From the many discussions of whether GET nodes should be savable ( e.g. #504 (comment) ), it seems like it's good to leave this up to users.

@jcelerier
Copy link
Member Author

jcelerier commented Mar 1, 2022

I assume that a device-wide configuration is not enough, and that this needs to be set per-parameter ? (with potentially the defaults being set in the device)

@jcelerier
Copy link
Member Author

@evanmtp any chance you could send me a quick Max patch which I could use for testing the feature ?

ideally something with a device, a few parameters in various modes and the objects needed for saving / reloading presets so that I can test that it works (e.g. with the @saveget things already set, even if the attribute is not there yet)

The reason is that I don't have a Max license so I cannot save patches... which makes testing a fairly frustrating experience

@evanmtp
Copy link
Contributor

evanmtp commented Mar 3, 2022

How's this?

----------begin_max5_patcher----------
3615.3oc6cs0iipbD94Yk1+CHqn7zjQ8Mng7zdNRQaRThTzYOJurJxBay5gM
XvBvyN64n7eO8MLM9BzX2fY1YVo0d3hs65qtzUWU0E+96e2cyVj8bTwLm+ry
mct6temcl6Dmiel6pNwcy1D97xjvBwMNKM5aYK95r6UWqL54Rw425rMOpHpr
XdY17xmKm+k3D12c08ktaSbZB6x7aFnc1rckUmFVc53UhuR1uyeh3s+qXaX4
xGiSWOOOZYobPSbe.buCFveEhP723u57ep9Lxu8xuuMR9AlMq9ZhuunbEwVQ
s2MiOveJJuHNKUeTc2rvsa0N+c5eHNH80Lw2k+80mKNUdNT84xidJt5qP6zg
4LZqjQX6xEC0YO6Qlo8MksJJOcWrX.oN6+68ua+PSveRC2DUrMbo7KfyG2e8
ZHC4CC33T.k+pG1m+Fg5qgZLYf0IYK+uQqzYVLvbaTZbpfMmVFVpHh5quJ5K
g6RXb9rzxh3eSLLfblxotgunFmm9pbRQPE+TdbXRMcrNOdUVJefz.+Dmu5m7
yNPgXA+UMZRbKogaO0GmIow.nlWsdfUvH1cEKBy4btEIQM+rkYYIMuVsDSRz
WJUWeabZ5g.ZY11VtZd75Ga6SuHic0Ms90KtTw7coxKOmIkTNuH7oCP9xvjD
kd8A+BOGlFuIrLpLVxOPf5qFkFxH3GKVlmkjzjtkW5oScoUL4+kQeKdU4ihe
rFhGrOP71JAqY0r8UwqiJJO3jkgqKN3TEkeWxBzO2tEJM84kQa1lvnFwcD8T
X575aio+DWTV7X12JT2dkLXC7n1bYC0ecylMuvAlOWlsYCS6oV0V2F5uDsjw
IbhdNjMNibxxc1UDk6vTLhYbuJCrNM9vIrKsLaWZYSCJ7QztEGJPdjk3FWog
h2+HrLy4WhVuKILe1wesEwqhN5Wro4bf9kzLoiIM99NgYcLcuBL6UpvttGQW
atB1VlkHsv9YljD9dsWfGd6mypTMMw+B2DluNVZ2Gr+FXVZq9atQ2gg4+onR
GN567GcXPxiNL3unLKORw1eoyzwcwzg5yk68CCOuo+RMY4gKJxR1UFw42yLi
ccZOlNBsgcphoTtvh2nAG45zYcex5HDyokhv0QmFhVEsIatTC.8.ysxyCSnK
.l.cASDjPdLPJUBvu.fIn0gITfgRSSAXpM8MF.wbtqZhTmjrvUVUsC40EPgf
BHR8FDRmnH0xrzujkuQLQD6C4rHKq7hfJz4fJWCgJnu7M4DCl.U26LKlOyn8
QrE6Xdbmdv.OmM4YIy4RoOuGMG3UKSALDnjJeHR0qc.SKBSWO1RU7kVshsdt
r0VUVB5aprjzZtWPODktE3zvq84al2XPp+jQ4qGF1Eqv0lJgPWyvqlxYSR65
aVvV6fy+5m90+pyE6nvYUDIFJV4RjNJzGEweTLnCglARu.rmy0ytB643yfPl
ZbRhMd98QHZ.snK+AuHj3bqZlXpcGWsEOyesITTE2gFAFS7SktJ5Y8XJeHZn
E+TdLGNWvuDCL9MbFbpHaW9xJ9PkRfyAixUQEkwo6iq7m2KLvuQy4V8erPLc
rfFgAiuwCF2Aevv88zrACb3QlJ50.jwa3GLFylfi.aJvzACFN3CFLnuCF86b
S7psYLGHKpB+RvCt70I6+.h8NlYwe+gCKU.6qZXKTQ0vVMSELX+QCJMXtHJY
3MqYrxKYDzW756foElqhchHXkiZUGbVRn5B04uU5H0bYVHmGVVlGy7LUNaai
TS2yLjsNIaQXxAoy5jYPa+HR7Gp2Uv80UW.7frwCcoCmrDqLaQ7oqJ.XOpJ.
baUEfmbU9pPrEXVUAbwDNmt1cgjD+yt2S500NO1fVIcSqp.u5BFXZ0blrVFq
tbtLpaJe+JtcmLj9ZaP5vtIcUtafHuWJR3EmQBGX.elLRh3Ct5rALVO2aq57
VmMe+SeOs7w+cbz25UIbANAEWKJqk4VHmz.Of7PThKHvGfCPPO9oBPtj..Lv
CP8IXXyr5dxbzAzgq.3wf1qyJ8B6IqwKnDeHtBjARnuUpWuUpWuUpWCdod8k
jLlwQaEbYdBgBE3hW+CLOsyD3CpienKXhmdrLF+K7g7nMYkQrYp943wM5yX8
kW.n8L5yCAXMgjzbMrTQdYJp8oKL99mSVyyPzpZsrtuIrcReoOa1Q7dAKr8Q
KKrgLDspD17l.BacCWOwVhR0xUraN+Mad.k20PH4pS4+PkrM5zIWaFGSZZ2Q
UWD2UeRckhq+2xbCiUwlcfiztwwS13bEHIEL.TSWpCTDVUflGXJy3v1OBoby
3f12IHCoDcYGftviFHqtsAGjMO+ysBxutxqv9XT8OyVEkb0AoBMRAoRUO49u
EjJk8NhbhSHV.1Dfm7n2BR0aAo5sfTM7Aop0cUB3AqtORBLqX1ja9OWvTcu1
XYTwfpcD7R.VPP6hKcuWZ7mJhKcuJ08QHQDuRmOvm.04m+aFtoNu1x8mXHTp
lmBHlJF6cyJK69gm7MNqDP+ze4WGIDEanRKT2quWLH5G2inebzPTjoac.Ifh
m7.JG+RtMQlpROVGqljQlx30zyqvUX60gmXs5dH9qttU+8vVjn8ItZsO5gtA
0CeX.XTF+j9DbmNP+.M3Gi5F++wLXEGzfGzZtCZcxgBm3TmPmUwKquwSZWcl
9Rame5a4398vYJYoN6yCFDjDbGMiol6sYwaj.8XbXd6a3bstg1ZaCVkio5EK
UrLQq3X0KVNGhZBmyW2akoNmqsBxTj8tqsFLQsVpdpsbkpHL8LoT8zyo3kPw
b4NQ9t5EocJwgf1KBQ8pPDq5QA9n8QA+RF6GrzwZ1UdT3JGs1WQwCesndKYd
5UQZ.yChLg4U0aAF5ZDuLbQMkGtPMo4LUC6f6ippEmT+m3FcptymecijAvmB
gZsF5QTfVRmfT3QaC0iQH9F+9fbAa0H9q1j24BKyWs5MzyD5W1gA8ouFEPnF
.PUy1OkDPDyUe8xGAlP9RCI9t2rJ0VJLLeSXJy7Z906VhIvE5TyVZhAWrbip
DDbzp2O8J24y3wFpg4e+Uee6D5hE8DMWorlu7MWWvaIJ6sDk8pJQYidNxZKV
ekNKbRra2Lp6n0KMlVMEjrFmPl0gPtAgC09PTmIRj3qVOlV4ediQnAn6f3an
fB1CbccGDz3lIQ9RBsZpDgcltFB1UWfwahlLwhnDG8XaXmt1DxPzQkPAOxDP
cpUAnukybIytRPclyEW2WuRPTCAmoj.jIsStNjifCPQMnB9lRLxep2IUOxT8
0mfX3kVDCpI8Uwsz0yzLDO1VmVlDcP209ZsNQ5b9MZy42tksc1aQO2izo4a0
dkFoZlBS4ttWkt25Kzcxy1MrQltvCjVgWMAMNwWvwktjC7E2Q0qJ2B0tsuuq
43l4rDugoxjnRBWF47Gfib+UupGlHMc6OU8Z52RbJRhY.Dzp9MgLXuFCzVAm
K8F2uTaCiDYmj4uT9H2R0UPjZCVPBl7dLIU0J4wEypHkgaXQk06oaOJVHHsN
Oa2V6V0bF1DDT1h7L006F4nXzApKxdD4bPjmoQTR0hhgFF5QML59FaXX8OUG
0+0Avzcyh1r3f.majyj52wlvsa2eO02hFyaTsMTXYO5f.CK7aU.dnjIpIAlw
fxHm84IS8fQRVH.Nqh3UUjXoncshc54wP5E2PKzZGHtn91LpO5+is6e0Iezp
d9YXCmQ9F8VFlCAcddhGbAyDa3DMs1yta4IW4U1SumT4vvPmVTw1w9M37AKE
Faxdx9qmp60KPzWgtm2jtmT.mFMV.iaOFvgu6Yy62Bt1o+XPXdv5o+OeOlGa
XYrQEUqe.dD5dDXiZE39c2mkCHUOJZ3aw.WYK0lezfSBHiHAT2j.H3AnNGwk
tmfPdiHAAsT6Ym+D3.q+OTPkHFue3LVhXlo7RGEkWhQiktkUvT+G70gVHoBZ
IjwAZI8YyYAF91wuYpgftkZwtRUM4y1JBY+QCOMXllmAJdtMZTvGcPU4KKqM
HJXLnsdoF1FwAIZ7GIILBrGietUfFgGhFFCmiyS5DXedrqzlUMBUL6szPFFD
r+nIxC7AHX5zGqF9GDFP5DRlG50y1TWadZI8lBSjgiQ6ngmDf84IIUazfu+w
9uqnnJMmgmhPlRQivyPFi0bf3gev.5oI5t27zDOsI7HC9iGHyeDrA6ti5oVQ
IxUWgSbzvRCXKRCJ+pGaZ.YS9fxguQlDvnIziZJruMwS2ahLAwlxDTfmbTGn
EnAwQCKMXScS5sQ2zyhjfG3lnaFX5D3lXkG.tUjf0Lx6eS3Bl+LFE5Yr2s.r
t2s.7XPCPaQCTU1uLmFzREgX6hctbQreKH92C2jsIb9iwqYz45GK4UWPdXZi
b1Ts4EOCHDtbYTZ4wsDV26cj4v6vw685.bN6ydhc1FGMX+jwMp5fWcMvWYWx
RtqBq1Ey7hhx4CpmdVLInOndpgU8mKhqq.ulkZta2awY2qcGgSOUOBF7.j2K
f4xCTQ6.l+W9ADHz2ftBrqVeWgJLIQo8bSjKu4lYmSwYNTEuh+b7b0MMOYTN
mNZ9MYf5PBMDU5YPv1aZHlO.85w.zF+d.aAHHYwMn7ijhsEfXMFVf3MECKn1
qvqa7QMY7gPsN.kiIL0SeJBpmkPvC+wuDHTMnHxs6EFezAHYIUUw8I1h6iMY
rSH1SevHvh.r2OHznePq86gLRgBhr2OXyHq0dp0Ni3GlnK94JKe9lGAcIxxS
Spr6ZKIPXfETvQToIR+.cmw8Cr0XjZBDC6.ikMSRDQVajpQLwZ3nm8vQLsQ3
to91ZLhMBG8LAGwXcbTbjcFiHafiZHWG3nxqqCZsLhg2gsTlCamLmnUxzRaj
4nVHiZ0Amq0w792wtg+OQqIHf
-----------end_max5_patcher-----------

I don't remember if we discussed this, but is the idea that @saveget, @saveset and @savebi would be set on the ossia.device? That's what makes sense to me.

@jcelerier
Copy link
Member Author

hum, there's something I don't understand - as I can see in the code, as of today, all the json and non-json preset saving already has

(param->get_value_type() != ossia::val_type::IMPULSE  && param->get_access() == ossia::access_mode::BI )

must investigate deeper...

@jcelerier
Copy link
Member Author

and that's been the case since early 2021 (thanks @avilleret !): 6a928d1

@jcelerier
Copy link
Member Author

this is even more bewildering to me, I added tests to check and can still not see the offending nodes in the presets.. a46ec8b#diff-b4761634b8d777aba2da2212388b35a10843a986f0b6efd6ea176a9e2d1bc09cR281

@evanmtp
Copy link
Contributor

evanmtp commented Mar 12, 2022

I think this can be closed now - please see my comment in https://github.com/ossia/libossia/issues/764#issuecomment-1065940288. Thank you!

@evanmtp evanmtp closed this as completed Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To do
Development

No branches or pull requests

2 participants