Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject doesn't flush MPC #61

Closed
drusk opened this issue Jul 3, 2013 · 1 comment · Fixed by #63
Closed

Reject doesn't flush MPC #61

drusk opened this issue Jul 3, 2013 · 1 comment · Fixed by #63

Comments

@drusk
Copy link
Contributor

drusk commented Jul 3, 2013

For the reals task, rejecting doesn't check whether it should flush the MPC lines it has buffered (it should be checking and flushing when the source is finished).

@ijiraq
Copy link
Member

ijiraq commented Jul 3, 2013

yes. just ran into that. We rejected all the observations of a particular source which then resulted in a zero length .mpc file. Interesting question of what to do when all source observations have been rejected. Just write out the mpc file for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants