WebRTC: Fix no audio and video issue for Firefox. #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johzzy
changed the title
winlinvip
force-pushed
the
develop
branch
25 times, most recently
from
be660c8
to
1fe12b8
Compare
winlinvip
force-pushed
the
develop
branch
2 times, most recently
from
14b8d86
to
4126c42
Compare
winlinvip
force-pushed
the
develop
branch
11 times, most recently
from
9c7a9d0
to
38c3d9f
Compare
winlinvip
force-pushed
the
bugfix/3041
branch
from
d40b569
to
33c6f56
Compare
winlinvip
reviewed
Nov 21, 2022
lipeng19811218
approved these changes
Nov 21, 2022
winlinvip
changed the title
winlinvip
changed the title
winlinvip
added a commit
that referenced
this pull request
Nov 22, 2022
* Remove extern SrsPps* duplicate declarations * fix(rtmp2rtc): fix video payload type for rtmp to rtc bridge (#3041) * Revert changes not belongs to this PR. * Fix naming issue, follow SRS style. * Use srs_assert instead of assert. * Fix firefox no audio issue. Co-authored-by: winlin <winlin@vip.126.com>
johzzy
added a commit
to johzzy/srs
that referenced
this pull request
Jun 26, 2023
* Remove extern SrsPps* duplicate declarations * fix(rtmp2rtc): fix video payload type for rtmp to rtc bridge (ossrs#3041) * Revert changes not belongs to this PR. * Fix naming issue, follow SRS style. * Use srs_assert instead of assert. * Fix firefox no audio issue. Co-authored-by: winlin <winlin@vip.126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3041
After the RTC starts streaming, the video payload type corresponding to the RTC source will change due to the SDP negotiation result.
If rtmp to rtc or srt to rtc occurs afterwards, the bridge constructs the video payload type of the rtp packet as the default value 102. This mismatch with the previous situation causes the webrtc receiver to not correctly obtain the video track.
Solution: Set the value of the video payload type for constructing the rtp packet in the bridge to match the video payload type of the rtc source.
TRANS_BY_GPT3