Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitive switch does not work for RegExp #61

Closed
mkpelletier opened this issue Jan 28, 2021 · 3 comments
Closed

Case sensitive switch does not work for RegExp #61

mkpelletier opened this issue Jan 28, 2021 · 3 comments

Comments

@mkpelletier
Copy link

I have a keyword/phrase defined in RexExp format with the case sensitive option deselected. Ostensibly, the option is only valid for non-RegExp keyword types, since the option has no effect, whether on or off, if RegExp is used. It would be helpful if the option could simply apply the /i RegExp switch to the entry, since there is no way to include the switch in the keyword space. Alternatively, the RegExp switches could be accommodated somewhere else. Having /i or /x available really helps simplify some use cases.

@otacke
Copy link
Owner

otacke commented Jan 28, 2021

Hi @mkpelletier Good idea! There you go: 60798c4

Please note that I don't know when the H5P core team will have time for releasing an update though. That will still have to run through them for quite a while before they have established a similar solution as we have for WordPress plugins today.

@mkpelletier
Copy link
Author

Thanks @otacke! Looks great. We are using the commercial implementation of H5P, so who knows when we'll see this patch come in. I'll plug it in to our Moodle server and have a go though.

All the best

@otacke
Copy link
Owner

otacke commented Jan 28, 2021

@mkpelletier I see. Feel free to close the issue if you think it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants