Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass 'i' flag to regex if !caseSensitive #78

Closed
mkpelletier opened this issue Mar 14, 2022 · 3 comments
Closed

Pass 'i' flag to regex if !caseSensitive #78

mkpelletier opened this issue Mar 14, 2022 · 3 comments

Comments

@mkpelletier
Copy link

This may be some low-hanging fruit that will greatly simplify regular expressions. Rather than specify caseSensitive in the Regexp options, use the configuration settings. This would allow users to make use of the i flag when writing their expressions.

@otacke
Copy link
Owner

otacke commented Mar 14, 2022

Where do you think a call to https://github.com/otacke/h5p-essay/blob/master/scripts/essay.js#L899 is missing? Feel free to create a pull request.

@mkpelletier
Copy link
Author

Ah, thanks... I missed that. Is this live on h5p.com? It doesn't seem to work there. It is funny because I remember suggesting this patch several years ago.

@otacke
Copy link
Owner

otacke commented Mar 14, 2022

Yes, this is live on H5P.com as far as I know, but you may want to ask the H5P core team for H5P.com support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants