Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_storage() with a root_path enters infinite loop if root_path ends with '/' #55

Open
Mark-Hetherington opened this issue Mar 23, 2023 · 0 comments · May be fixed by #56
Open

fix_storage() with a root_path enters infinite loop if root_path ends with '/' #55

Mark-Hetherington opened this issue Mar 23, 2023 · 0 comments · May be fixed by #56

Comments

@Mark-Hetherington
Copy link

Within _gcsfs.py in the fix_storage process if the root_path ends with a slash, there is an infinite loop. This is because the dirname function will return each parent directory without the trailing slash.

I think this can be resolved easily, by a safety check for a trailing slash on the root path when the file system is created.

@Mark-Hetherington Mark-Hetherington linked a pull request Mar 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant