Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added A LOT of missing items up to version 10.98 #3508

Merged
merged 6 commits into from Jul 29, 2021

Conversation

EPuncker
Copy link
Contributor

@EPuncker EPuncker commented Jul 25, 2021

Pull Request Prelude

Changes Proposed

  • Added lots of missing items up to version 10.98 based on client files
  • Fixed all articles
  • Fixed most of the names

we can say we have like 99% of the items right now

all of that possible thanks to @MillhioreBT and @jo3bingham and @giuinktse7

and fixed missing "fromid" at item id 17259
@EPuncker EPuncker changed the title Added a few missing items Added A LOT of missing items up to version 10.98 Jul 27, 2021
@EPuncker EPuncker added the enhancement Increase or improvement in quality, value, or extent label Jul 27, 2021
Co-Authored-By: Sarah Wesker <sarahelizabetwesker@gmail.com>
EPuncker and others added 2 commits July 27, 2021 02:40
Co-Authored-By: Sarah Wesker <sarahelizabetwesker@gmail.com>
ranisalt
ranisalt previously approved these changes Jul 28, 2021
@Zbizu
Copy link
Contributor

Zbizu commented Jul 28, 2021

Items load properly so syntax is alright.
Loading monsters spat out several warnings:

[Warning - Monsters::loadMonster] Non-unique loot item "power bolt".
[Warning - Monsters::loadMonster] Cant load loot. data/monster/monsters/dragon_l
ord.xml
[Warning - Monsters::loadMonster] Non-unique loot item "dragon lord trophy".
[Warning - Monsters::loadMonster] Cant load loot. data/monster/monsters/dragon_l
ord.xml
[Warning - Monsters::loadMonster] Non-unique loot item "burst arrow".
[Warning - Monsters::loadMonster] Cant load loot. data/monster/monsters/dragon.x
ml
[Warning - Monsters::loadMonster] Non-unique loot item "arrow".
[Warning - Monsters::loadMonster] Cant load loot. data/monster/monsters/elf_scou
t.xml
[Warning - Monsters::loadMonster] Non-unique loot item "arrow".
[Warning - Monsters::loadMonster] Cant load loot. data/monster/monsters/elf_arca
nist.xml
[Warning - Monsters::loadMonster] Non-unique loot item "grave flower".
[Warning - Monsters::loadMonster] Cant load loot. data/monster/monsters/elf_arca
nist.xml
[Warning - Monsters::loadMonster] Non-unique loot item "halberd".
[Warning - Monsters::loadMonster] Cant load loot. data/monster/monsters/black_kn
ight.xml
[Warning - Monsters::loadMonster] Non-unique loot item "arrow".
[Warning - Monsters::loadMonster] Cant load loot. data/monster/monsters/elf.xml
[Warning - Monsters::loadMonster] Non-unique loot item "halberd".
[Warning - Monsters::loadMonster] Cant load loot. data/monster/monsters/cyclops.
xml
[Warning - Monsters::loadMonster] Non-unique loot item "arrow".
[Warning - Monsters::loadMonster] Cant load loot. data/monster/monsters/hunter.x
ml
[Warning - Monsters::loadMonster] Non-unique loot item "burst arrow".
[Warning - Monsters::loadMonster] Cant load loot. data/monster/monsters/hunter.x
ml
[Warning - Monsters::loadMonster] Non-unique loot item "halberd".
[Warning - Monsters::loadMonster] Cant load loot. data/monster/monsters/orc_bers
erker.xml
[Warning - Monsters::loadMonster] Non-unique loot item "cherry".
[Warning - Monsters::loadMonster] Cant load loot. data/monster/monsters/bug.xml
[Warning - Monsters::loadMonster] Non-unique loot item "grave flower".
[Warning - Monsters::loadMonster] Cant load loot. data/monster/monsters/vampire.
xml

Regarding changes in items.xml itself, the names themselves look alright, but I do recommend re-checking item attributes @EPuncker, see: https://github.com/otland/forgottenserver/pull/3508/files#diff-91ad02cf0392428a8eee4cac4012de4c8f3b42319fd87ee93bf2873b19461875R13166 for example (flame of life has poem description) nevermind, diff loader messed up the view, raw file is ok

Zbizu
Zbizu previously approved these changes Jul 28, 2021
@DSpeichert
Copy link
Member

Probably worth fixing non-unique loot item names?

@EPuncker EPuncker dismissed stale reviews from Zbizu and ranisalt via bf062b1 July 29, 2021 14:39
@EPuncker EPuncker merged commit 9ad03d5 into otland:master Jul 29, 2021
@BahamutxD
Copy link
Contributor

I've been reviewing items.xml for some time now and haven't been able to find a single issue.

My idea was to eventually do the whole thing but seeing how I am unable to find any issue after 15-20% of the file reviewed + a fast look over the whole thing - I find it safe to assume it's for the most part good to go.

@EPuncker EPuncker deleted the missing-items branch August 6, 2021 03:02
@Alkenix
Copy link

Alkenix commented Aug 11, 2021

image
Downloaded the latest branch monster folder (last edit by EPuncker) and fixed all of them in it.
But I dunno how to get them into the latest branch.. Sorry.
So here are the changed luas:
changes.zip

@ranisalt
Copy link
Member

@Alkenix check #3540 #3538

@Alkenix
Copy link

Alkenix commented Aug 11, 2021

@ranisalt Yep. Still had the errors. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Increase or improvement in quality, value, or extent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants