New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added A LOT of missing items up to version 10.98 #3508
Conversation
and fixed missing "fromid" at item id 17259
Co-Authored-By: Sarah Wesker <sarahelizabetwesker@gmail.com>
Co-Authored-By: Sarah Wesker <sarahelizabetwesker@gmail.com>
thanks to @ranisalt
Items load properly so syntax is alright.
Regarding changes in items.xml itself, the names themselves look alright, |
Probably worth fixing non-unique loot item names? |
I've been reviewing items.xml for some time now and haven't been able to find a single issue. My idea was to eventually do the whole thing but seeing how I am unable to find any issue after 15-20% of the file reviewed + a fast look over the whole thing - I find it safe to assume it's for the most part good to go. |
|
@ranisalt Yep. Still had the errors. :) |
Pull Request Prelude
Changes Proposed
we can say we have like 99% of the items right now
all of that possible thanks to @MillhioreBT and @jo3bingham and @giuinktse7