Use item id instead of name in monster loot

[marmichalski]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Issues addressed: #3528

[marmichalski]

If you prefer, I can keep (& add missing) comments with item name 🤔

[Zbizu]

Why did you remove the comments on item ids? It tells exactly what the user is editing and makes the whole thing readable.

If you're using a script to convert that, call ItemType(itemId):getName() on each item id to generate comments again.

[marmichalski]

Why did you remove the comments on item ids? It tells exactly what the user is editing and makes the whole thing readable.

#3538 (comment)

Keeping the comment here also makes it easily outdated when items.xml are changed. There were already a few missing names used.

If you're using a script to convert that, call ItemType(itemId):getName() on each item id to generate comments again.

Do you just type things for the heck of typing?

[soul4soul]

I'd rather have the item names and run the risk of duplicate item name. At a minimum the item names have to be kept as comments to make editing the files manageable.

[marmichalski]

Will this be stalled until merge conflicts arise?

[Erza]

To help with your decision: id's should be used because of name duplication - you can't reliably use item names as loot because multiple items can have the same name and the engine will pick the first id that it finds.

Now when you look at #3540, non-unique item names use id's instead, but for one, that's inconsistent, and for two, nobody wants to maintain that. It's not future-proof, if item names ever get corrected and one ends up with a duplicate name

Just use id's across the board and merge this PR.

[marmichalski]

@EPuncker beep boop

[Erza]

smh

[EPuncker]

@DSpeichert this can be merged, I can't approve it because my browser lag with so many files

[DSpeichert]

I think someone suggested keeping both id and name parameter, instead of moving the name out to a comment. It's easier to write and it's also more portable. IIRC, the engine will prefer id, if exists, before reverting to name.

[marmichalski]

kthxbye