Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the pidgin plugin #16

Closed
5 tasks
juniorz opened this issue May 8, 2017 · 6 comments
Closed
5 tasks

Refactor the pidgin plugin #16

juniorz opened this issue May 8, 2017 · 6 comments
Labels
architecture importance medium An issue that is medium level importance. It's good to have but not 100% necessary. pidgin plugin

Comments

@juniorz
Copy link
Member

juniorz commented May 8, 2017

There are a few things we could probably remove, like:

  • ConnContext. Remove the functions:
    • otrg_plugin_context_to_trust
    • otrg_plugin_conv_to_selected_context
    • conn_context_to_plugin_conversation
  • Handle warnings
@juniorz juniorz added this to the Working prototype milestone May 8, 2017
@juniorz juniorz self-assigned this May 11, 2017
@tdruiva
Copy link
Contributor

tdruiva commented May 15, 2017

Do you think auto generate key is part of this refactoring or it can be a different task?

@juniorz
Copy link
Member Author

juniorz commented May 16, 2017

#20 created ;)

@juniorz
Copy link
Member Author

juniorz commented May 24, 2017

@tdruiva and I tried (and failed) to do it. It's hard to remove all the dependencies on libotr3 when the plugin has no tests.

I'm gonna close this because I don't want to encourage us to use more time on this.

@juniorz juniorz closed this as completed May 24, 2017
@juniorz juniorz reopened this Jun 6, 2017
@juniorz
Copy link
Member Author

juniorz commented Jun 6, 2017

We know better what needs to be removed. Not that we want to remove them now.

@claucece
Copy link
Member

claucece commented Apr 7, 2018

For the moment, please, don't look at this issue. It should be moved once we move the work to the pidgin plugin.

@claucece claucece removed this from the Working prototype milestone Apr 7, 2018
@claucece claucece added importance high An issue that is absolutely necessary to have done before final release and removed waiting labels Jun 26, 2018
@claucece claucece added importance medium An issue that is medium level importance. It's good to have but not 100% necessary. architecture and removed importance high An issue that is absolutely necessary to have done before final release labels Jul 2, 2018
@claucece
Copy link
Member

claucece commented Sep 9, 2018

This will only be reference as we have the appropriate issue on the pidgin plugin repo.

@claucece claucece closed this as completed Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture importance medium An issue that is medium level importance. It's good to have but not 100% necessary. pidgin plugin
Projects
None yet
Development

No branches or pull requests

3 participants