Issue 4099 add a preference for the preferred locale for a user. #1866

zz9pzza · 2014-10-04T22:20:42Z

This adds the preferred locale user preference, currently the ability to edit this preference is controlled by roll out.

https://code.google.com/p/otwarchive/issues/detail?id=4099

…ace to be used in different locales ( adds the admin preferences )

coveralls · 2014-10-05T08:59:33Z

Coverage increased (+0.17%) when pulling 4367bd5 on zz9pzza:issue_4099 into a97eeff on otwcode:master.

…ssue_4099

coveralls · 2014-11-06T21:34:05Z

Coverage increased (+2.77%) when pulling fdecc60 on zz9pzza:issue_4099 into fc2934d on otwcode:master.

… issue_4099

sarken · 2014-11-16T23:39:42Z

app/controllers/archive_faqs_controller.rb

@@ -119,7 +119,11 @@ def set_locale
    if params[:language_id] && session[:language_id] != params[:language_id]
      session[:language_id] = params[:language_id]
    end
-    @i18n_locale = session[:language_id] || I18n.default_locale
+    if current_user.present?  && $rollout.active?(:set_locale_preference, current_user) then 


Is then something special required for rollout? If not, it should probably come out -- it's not standard syntax for us.

sarken · 2014-11-17T05:52:02Z

There were quite a few interface, code, and accessibility issues with the locale views, so rather than go through and leave a million comments, I made the changes myself. You might want to pull them in: https://github.com/sarken/otwarchive/tree/issue_4099 But if you don't, we can make a separate issue and pull request for them.

…o issue_4099

…ssue_4099

sarken · 2014-11-19T02:54:50Z

app/views/preferences/index.html.erb

-    </dl>
-  </fieldset>
+</fieldset>
+  </ul>


This </ul> shouldn't be here.

sarken · 2014-11-19T03:04:25Z

Just two little things that got overlooked! (I commented on them.) Then someone else can give this a once-over from a backend POV.

(The test failure is for importing and seems to be unrelated.)

coveralls · 2015-05-03T22:51:17Z

Coverage decreased (-1.28%) to 72.47% when pulling ccfd466 on zz9pzza:issue_4099 into 30d7f56 on otwcode:master.

coveralls · 2015-05-03T22:51:17Z

Coverage increased (+0.07%) to 73.82% when pulling ccfd466 on zz9pzza:issue_4099 into 30d7f56 on otwcode:master.

sarken · 2015-05-04T19:47:32Z

public/help/locale-preferences.html

+<dl id="help">
+  <dt>Set preferred locale</dt>
+  <dd>
+This preference allows you to select your prefered language for email messages that the Archive sends to you. The templates for these messages are currently being updated and translated by our volunteers. This is a work in progress; not all messages will be available in languages other than English at this time. If the template for that email has not yet been translated to your language, it will be sent in English.


One last "prefered" snuck in here.

sarken · 2015-05-07T00:19:20Z

I think the test failures we're seeing might actually be related to this: Mysql2::Error: Unknown column 'locales.email_enabled' in 'where clause': SELECT locales.* FROM locales WHERE locales.email_enabled = 1 (ActionView::Template::Error)

…ssue_4099

…for testing so we can automate the generation on deploying to test

coveralls · 2015-05-08T19:33:30Z

Coverage decreased (-5.69%) to 68.12% when pulling 4f9b118 on zz9pzza:issue_4099 into 6fc124f on otwcode:master.

coveralls · 2015-05-08T19:33:30Z

Coverage decreased (-5.69%) to 68.12% when pulling 4f9b118 on zz9pzza:issue_4099 into 6fc124f on otwcode:master.

coveralls · 2015-05-09T06:33:56Z

Coverage decreased (-1.27%) to 72.54% when pulling 8e6c0c8 on zz9pzza:issue_4099 into 6fc124f on otwcode:master.

coveralls · 2015-05-09T06:33:56Z

Coverage decreased (-1.27%) to 72.54% when pulling 8e6c0c8 on zz9pzza:issue_4099 into 6fc124f on otwcode:master.

coveralls · 2015-05-09T06:33:56Z

Coverage decreased (-1.27%) to 72.54% when pulling 8e6c0c8 on zz9pzza:issue_4099 into 6fc124f on otwcode:master.

coveralls · 2015-05-09T06:33:56Z

Coverage increased (+0.02%) to 73.83% when pulling 8e6c0c8 on zz9pzza:issue_4099 into 6fc124f on otwcode:master.

ariana-paris · 2015-05-10T06:57:09Z

app/views/locales/index.html.erb

+          <td><%= locale.interface_enabled %></td>
+          <td><%= locale.updated_at %></td>
+          <td class="actions">
+            <%= link_to ts('Edit'), {controller: :locales, action: :edit, id: locale.iso} %>


This is a remaining ts() in a file that seems to otherwise use t()

Issue 4099 add a preference for the preferred locale for a user.

zz9pzza added 6 commits October 3, 2014 21:36

Add fields for locales to allow emails to be sent and the user interf…

c6668cc

…ace to be used in different locales ( adds the admin preferences )

Make test not go bang

756b9c7

The ability to change the prefered locale is now controlled by roll out

89d8037

If the user has a locale preference then honor it in the FAQ's

da94fdf

remove debugging code

34fe64d

Make the preference visible in the testing enviroment

4367bd5

Update text used in label

8be49cf

scottsds mentioned this pull request Oct 14, 2014

Issue 4106 i18n kudos email #1878

Merged

Merge branch 'master' of https://github.com/otwcode/otwarchive into i…

fdecc60

…ssue_4099

Merge branch 'issue_4099' of git://github.com/zz9pzza/otwarchive into…

29347a2

… issue_4099

sarken reviewed Nov 16, 2014
View reviewed changes

4099 Locales front end suggestions

1c09f7e

sarken added the Reviewed: Action Needed label Nov 17, 2014

zz9pzza added 3 commits November 18, 2014 17:59

Following Sarken's comments

753b43f

Merge branch 'issue_4099' of https://github.com/sarken/otwarchive int…

ad92811

…o issue_4099

Merge branch 'master' of https://github.com/otwcode/otwarchive into i…

fb64249

…ssue_4099

zz9pzza added Coder Has Actioned Review and removed Reviewed: Action Needed labels Nov 18, 2014

sarken reviewed Nov 19, 2014
View reviewed changes

app/views/preferences/index.html.erb

</dl>

</fieldset>

</fieldset>

</ul>

Copy link

Member

sarken Nov 19, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This </ul> shouldn't be here.

sarken added Reviewed: Action Needed and removed Coder Has Actioned Review labels Nov 19, 2014

I think that is what saren wished

b68ac08

sarken reviewed May 4, 2015
View reviewed changes

sarken added Reviewed: Action Needed and removed Coder Has Actioned Review labels May 4, 2015

One last typo

f6cecc3

zz9pzza added 3 commits May 7, 2015 16:37

Ensure the database is correct

e5754af

Merge branch 'master' of https://github.com/otwcode/otwarchive into i…

9e4509c

…ssue_4099

Update the sructure

d45b418

zz9pzza added Coder Has Actioned Review and removed Reviewed: Action Needed labels May 7, 2015

scottsds added Reviewed: Ready to Merge and removed Coder Has Actioned Review labels May 8, 2015

zz9pzza added 5 commits May 8, 2015 17:07

Put the db files back

cbc201e

Get travis to delete the current db state to make the files not used …

f72f979

…for testing so we can automate the generation on deploying to test

Try this travis

a38edb4

Try this travis

4f9b118

We need to do the migrations

826804a

Roll up the migrations properly

8e6c0c8

ariana-paris reviewed May 10, 2015
View reviewed changes

ariana-paris added a commit that referenced this pull request May 11, 2015

Merge pull request #1866 from zz9pzza/issue_4099

b0c5942

Issue 4099 add a preference for the preferred locale for a user.

ariana-paris merged commit b0c5942 into otwcode:master May 11, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 4099 add a preference for the preferred locale for a user. #1866

Issue 4099 add a preference for the preferred locale for a user. #1866

zz9pzza commented Oct 4, 2014

coveralls commented Oct 5, 2014

coveralls commented Nov 6, 2014

sarken Nov 16, 2014

sarken commented Nov 17, 2014

sarken Nov 19, 2014

sarken commented Nov 19, 2014

coveralls commented May 3, 2015

coveralls commented May 3, 2015

sarken May 4, 2015

sarken commented May 7, 2015

coveralls commented May 8, 2015

coveralls commented May 8, 2015

coveralls commented May 9, 2015

coveralls commented May 9, 2015

coveralls commented May 9, 2015

coveralls commented May 9, 2015

ariana-paris May 10, 2015

Issue 4099 add a preference for the preferred locale for a user. #1866

Issue 4099 add a preference for the preferred locale for a user. #1866

Conversation

zz9pzza commented Oct 4, 2014

coveralls commented Oct 5, 2014

coveralls commented Nov 6, 2014

sarken Nov 16, 2014

Choose a reason for hiding this comment

sarken commented Nov 17, 2014

sarken Nov 19, 2014

Choose a reason for hiding this comment

sarken commented Nov 19, 2014

coveralls commented May 3, 2015

coveralls commented May 3, 2015

sarken May 4, 2015

Choose a reason for hiding this comment

sarken commented May 7, 2015

coveralls commented May 8, 2015

coveralls commented May 8, 2015

coveralls commented May 9, 2015

coveralls commented May 9, 2015

coveralls commented May 9, 2015

coveralls commented May 9, 2015

ariana-paris May 10, 2015

Choose a reason for hiding this comment