AO3-4566 Update Gems for Ruby upgrades #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,7 +10,7 @@ gem 'rails', '3.2.22.2' | |||
|
|
|||
| # Database | |||
| # gem 'sqlite3-ruby', :require => 'sqlite3' | |||
| gem 'mysql2', '0.3.10' | |||
| gem 'mysql2', '0.3.20' | |||
There was a problem hiding this comment.
didn't we already change mysql2 to something higher? I might be totally misremembering...
There was a problem hiding this comment.
We have a pull request for it but it has yet to be merged.
|
Gone grey |
zz9pzza
added
Coder Has Actioned Review
Gem Updates
and removed
Reviewed: Action Needed
labels
|
Grey again |
|
Gone grey again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://otwarchive.atlassian.net/browse/AO3-4566
Looking at this I would just check that things work as the things changing look as if they are used every where eg mysql, memcached etc