AO3-4128-more thorough progress fix #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: astolat shalott <shalott@gmail.com>
| end | ||
|
|
||
| it "should have a signup key" do | ||
| expect(PotentialMatch.signup_key(@collection)).to include("#{@collection.id}") |
There was a problem hiding this comment.
Prefer to_s over string interpolation.
shalott
added
Priority: High - Broken on Test
Signed-off-by: astolat shalott <shalott@gmail.com>
| @@ -104,9 +104,14 @@ def self.generate_in_background(collection_id) | |||
| required_types = settings.required_types.map {|t| t.classify} | |||
|
|
|||
| # treat each signup as a request signup first | |||
| collection.signups.find_each do |signup| | |||
| # because find_each doesn't give us a consistent order, but we don't necessarily | |||
There was a problem hiding this comment.
What ordering problem did you find with find_each? The Rails documentation says: "[Order] is automatically set to ascending on the primary key (“id ASC”) to make the batch ordering work." So I would expect that to do what you want?
There was a problem hiding this comment.
Actually, in retrospect I realized the issue was likely because the job-restarting code was causing the process to start over and over on top of itself. However, I think this remains a better way of handling the progress (doesn't break if user changes name/pseud midstream), so would still rather get this in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://otwarchive.atlassian.net/browse/AO3-4128
The progress report was NOT fixed. I've reworked the way it was being done, and also added tests. Now hopefully working for reals. Tests running clean.
Signed-off-by: astolat shalott shalott@gmail.com