AO3-4956 Extend tests for opendoors/tools_controller.rb and change from 404 to flash error #2850
Conversation
- Display an error message instead of raising 404 when a work ID cannot be found. - Add controller spec for opendoors/tools_controller.rb. - Add a scenario for updating a work's imported from URL.
sarken
changed the title
| And I am logged in as "OpenDoors" | ||
| When I go to the Open Doors tools page | ||
| Then I should see "Update Redirect URL" | ||
| When I fill in "imported_from_url" with "http://example.com/my-immortal" | ||
| And I fill in "work_url" with the path to the "My Immortal" work page | ||
| And I submit with the 2nd button |
There was a problem hiding this comment.
Is there a reason that we can't use the buttons name as 2nd button feels fragile ?
There was a problem hiding this comment.
The tools page has 2 forms: one to change the imported URL and one to block imported emails. The first form has no id/class, and both forms have the same "Submit" button.
Can we change the submit button values?
There was a problem hiding this comment.
I couldn't get to the right place on test or my dev. I just wanted to make sure it was like that :(
I will @sarken to comment. I think what you have done is fine. If we wanted to have two buttons called Submit which I don't like we could have an extra div but I would prefer sarken had a look ?
There was a problem hiding this comment.
At some point, we should make the button text more descriptive, but I don't think we need to do anything about it now.
Issue
https://otwarchive.atlassian.net/browse/AO3-4956
Purpose
Testing
See https://otwarchive.atlassian.net/browse/AO3-4956.