AO3-5486 Script for getting user data #3393

sarken · 2018-07-16T21:25:49Z

Issue

https://otwarchive.atlassian.net/browse/AO3-5486

Purpose

Adds a script that will let database admins give Policy & Abuse a pretty dump of user data when they have GDPR requests for such things.

Testing

Run the script for a viclunteer. Instructions and example output are in the issue.

houndci-bot · 2018-07-16T21:25:59Z

script/get_user_data.rb

+    puts "  #{change}"
+  end
+end
+


Layout/TrailingBlankLines: 1 trailing blank lines detected.

houndci-bot · 2018-07-16T21:25:59Z

script/get_user_data.rb

+  puts
+  puts "User Agents:"
+  user_agents.uniq.map do |user_agent|
+   puts "  #{user_agent}"


Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.

houndci-bot · 2018-07-16T21:25:59Z

script/get_user_data.rb

+
+# List of user agents
+user_agents = []
+u.comments.pluck(:user_agent)&.map { |ua| user_agents << ua if !ua.blank? }


Style/NegatedIf: Favor unless over if for negative conditions.

houndci-bot · 2018-07-16T21:25:59Z

script/get_user_data.rb

+# Don't include IPs from the audits table because some IPs may be admins'
+ips = []
+u.comments.pluck(:ip_address)&.map { |ip| ips << ip if !ip.blank? }
+u.works.pluck(:ip_address)&.map { |ip| ips << ip if !ip.blank? }


Style/NegatedIf: Favor unless over if for negative conditions.

houndci-bot · 2018-07-16T21:25:59Z

script/get_user_data.rb

+# List of IP addresses
+# Don't include IPs from the audits table because some IPs may be admins'
+ips = []
+u.comments.pluck(:ip_address)&.map { |ip| ips << ip if !ip.blank? }


Style/NegatedIf: Favor unless over if for negative conditions.

houndci-bot · 2018-07-16T21:26:00Z

script/get_user_data.rb

+
+# Names of people listing user as their FNOK
+next_of_kin_for = []
+FannishNextOfKin.where(kin_id: u.id)&.pluck(:user_id).map do |id|


Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.

houndci-bot · 2018-07-16T21:26:00Z

script/get_user_data.rb

+
+# URLs of all nominations made in tag sets
+tag_set_nomination_urls = []
+TagSetNomination.where(pseud_id: u.pseuds.pluck(:id))&.pluck(:id, :owned_tag_set_id).map do |id, tag_set_id|


Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.

houndci-bot · 2018-07-16T21:26:00Z

script/get_user_data.rb

+# URLs of all works user has kudosed
+# Kudos can only be on works now, but there is a pull request for admin posts
+kudosed_item_urls = [] 
+u.kudos&.pluck(:commentable_type, :commentable_id).map do |type, id|


Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.

houndci-bot · 2018-07-16T21:26:00Z

script/get_user_data.rb

+
+# URLs of all comments
+comment_urls = []
+u.comments&.pluck(:id).map do |id|


Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.

houndci-bot · 2018-07-16T21:26:00Z

script/get_user_data.rb

@@ -0,0 +1,172 @@
+#!script/rails runner


Lint/ScriptPermission: Script file get_user_data.rb doesn't have execute permission.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

redsummernight

I tried it locally and it looks good! Minor comments not blocking merge.

redsummernight · 2018-07-21T03:52:18Z

script/get_user_data.rb

+# URLs of all comments
+comment_urls = []
+u.comments.pluck(:id)&.map do |id|
+  comment_urls << "#{comments_url}/#{id}"


"#{comments_url}/#{id}" can be comment_url(id).

redsummernight · 2018-07-21T04:07:54Z

script/get_user_data.rb

+# URLs of all nominations made in tag sets
+tag_set_nomination_urls = []
+TagSetNomination.where(pseud_id: u.pseuds.pluck(:id)).pluck(:id, :owned_tag_set_id)&.map do |id, tag_set_id|
+  tag_set_nomination_urls << "#{tag_sets_url}/#{tag_set_id}/nominations/#{id}"


This can be tag_set_nomination_url(tag_set_id: tag_set_id, id: id).

…add giant warning about deleting file

houndci-bot · 2018-07-21T22:17:40Z

script/get_user_data.rb

+  unless collection_roles.empty?
+  f.puts "Collection Roles: "
+    collection_roles.map do |role|
+    f.puts "  #{role}"


Layout/IndentationWidth: Use 2 (not 0) spaces for indentation.

houndci-bot · 2018-07-21T22:17:40Z

script/get_user_data.rb

+  f.puts "Collections: #{user_collections_url(u)}"
+  unless collection_roles.empty?
+  f.puts "Collection Roles: "
+    collection_roles.map do |role|


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-07-21T22:17:40Z

script/get_user_data.rb

+  f.puts
+  f.puts "Collections: #{user_collections_url(u)}"
+  unless collection_roles.empty?
+  f.puts "Collection Roles: "


Layout/IndentationWidth: Use 2 (not 0) spaces for indentation.

houndci-bot · 2018-07-21T22:17:40Z

script/get_user_data.rb

+
+filename_and_path = "/tmp/user_data_for_#{u.login}_#{todays_date}.txt"
+
+open(filename_and_path, "w") { |f|


Metrics/BlockLength: Block has too many lines. [81/25]
Security/Open: The use of Kernel#open is a serious security risk.
Style/BlockDelimiters: Avoid using {...} for multi-line blocks.

houndci-bot · 2018-07-21T22:17:40Z

script/get_user_data.rb

+
+# URLs of all nominations made in tag sets
+tag_set_nomination_urls = []
+TagSetNomination.where(pseud_id: u.pseuds.pluck(:id)).pluck(:id, :owned_tag_set_id)&.map do |id, tag_set_id|


Lint/UnusedBlockArgument: Unused block argument - id. You can omit all the arguments if you don't care about them.
Lint/UnusedBlockArgument: Unused block argument - tag_set_id. You can omit all the arguments if you don't care about them.

houndci-bot · 2018-07-21T22:17:40Z

script/get_user_data.rb

+# URLs of all comments
+comment_urls = []
+u.comments.pluck(:id)&.map do |id|
+  comment_urls << "#{comment_url(id)}"


Style/UnneededInterpolation: Prefer to_s over string interpolation.

houndci-bot · 2018-07-26T01:28:31Z

script/get_user_data.rb

+
+filename_and_path = "/tmp/user_data_for_#{u.login}_#{todays_date}.txt"
+
+open(filename_and_path, "w") do |f|


Metrics/BlockLength: Block has too many lines. [81/25]
Security/Open: The use of Kernel#open is a serious security risk.

houndci-bot · 2018-07-26T01:28:31Z

script/get_user_data.rb

+         "an unknown IP address"
+       end
+  if action == "create"
+    account_changes << "Created account #{changes["login"]} from #{ip} on #{date}"


Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.

houndci-bot · 2018-07-26T01:28:32Z

script/get_user_data.rb

+# admins' personal data
+account_changes = []
+audits = u.audits.pluck(:action, :audited_changes, :created_at, :remote_address)
+audits.map do |audit|


Metrics/BlockLength: Block has too many lines. [26/25]

redsummernight · 2018-07-26T02:05:33Z

script/get_user_data.rb

+      when "login"
+        account_changes << "Changed username from #{v[0]} to #{v[1]} from #{ip} on #{date}"
+      when "recently_reset"
+        account_changes << "Requested password reset from from #{ip} on #{date}"


There's an extra "from".

AO3-5486 Script for getting user data

382f917

sarken added Priority: High Awaiting Review labels Jul 16, 2018

houndci-bot reviewed Jul 16, 2018

View reviewed changes

AO3-5486 Clean up on aisle yikes

e991426

redsummernight approved these changes Jul 21, 2018

View reviewed changes

AO3-5486 Update comment and tag nomination URLs, write data to file, …

a3a3102

…add giant warning about deleting file

houndci-bot reviewed Jul 21, 2018

View reviewed changes

sarken added 2 commits July 21, 2018 18:37

AO3-5486 Tidy up for Hound

d80f3e1

Merge branch 'master' into AO3-5486

e6ad749

sarken added Reviewed: Action Needed and removed Awaiting Review labels Jul 25, 2018

AO3-5486 Include account creation in script

99bca95

houndci-bot reviewed Jul 26, 2018

View reviewed changes

sarken added Coder Has Actioned Review and removed Reviewed: Action Needed labels Jul 26, 2018

redsummernight reviewed Jul 26, 2018

View reviewed changes

AO3-5486 Remove extra 'from'

dbfd06a

redsummernight approved these changes Jul 26, 2018

View reviewed changes

redsummernight added Reviewed: Ready to Merge and removed Coder Has Actioned Review labels Jul 26, 2018

redsummernight merged commit 622fb94 into otwcode:master Jul 26, 2018

sarken deleted the AO3-5486 branch July 29, 2018 21:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AO3-5486 Script for getting user data #3393

AO3-5486 Script for getting user data #3393

sarken commented Jul 16, 2018

houndci-bot Jul 16, 2018

houndci-bot Jul 16, 2018

houndci-bot Jul 16, 2018

houndci-bot Jul 16, 2018

houndci-bot Jul 16, 2018

houndci-bot Jul 16, 2018

houndci-bot Jul 16, 2018

houndci-bot Jul 16, 2018

houndci-bot Jul 16, 2018

houndci-bot Jul 16, 2018

redsummernight left a comment

redsummernight Jul 21, 2018

redsummernight Jul 21, 2018

houndci-bot Jul 21, 2018

houndci-bot Jul 21, 2018

houndci-bot Jul 21, 2018

houndci-bot Jul 21, 2018

houndci-bot Jul 21, 2018

houndci-bot Jul 21, 2018

houndci-bot Jul 26, 2018

houndci-bot Jul 26, 2018

houndci-bot Jul 26, 2018

redsummernight Jul 26, 2018


		filename_and_path = "/tmp/user_data_for_#{u.login}_#{todays_date}.txt"

		open(filename_and_path, "w") { \|f\|


		filename_and_path = "/tmp/user_data_for_#{u.login}_#{todays_date}.txt"

		open(filename_and_path, "w") do \|f\|

AO3-5486 Script for getting user data #3393

AO3-5486 Script for getting user data #3393

Conversation

sarken commented Jul 16, 2018

Issue

Purpose

Testing

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

redsummernight left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment