AO3-5576 Use Devise::Recoverable. #3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Email links in the tests used to use a different host, which resulted in sessions being "lost" because the user was visiting a different path (and therefore had their cookies stored elsewhere). Now it's all the same host, so the test can be slightly simplified.
houndci-bot
reviewed
Dec 22, 2018
redsummernight
added
Priority: High - Broken on Test
|
For my own notes, we now have 2 forms to change passwords: one linked from preferences, requiring the old password, the other one from Devise, reachable by email, requiring an auto-generated token. |
houndci-bot
reviewed
Dec 22, 2018
redsummernight
added
Has Migrations
sarken
approved these changes
Dec 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-5576
https://otwarchive.atlassian.net/browse/AO3-5577
Purpose
Adds Recoverable to the list of Devise modules for Users, and tries to move over the existing messages/emails to the Devise system.
Testing Instructions
Reset password, follow instructions, make sure that the user experience is what you expect (error messages, good instructions and phrasing, and so on).