Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-5754 Fix min-length warning overlapping comment buttons #3673

Merged
merged 4 commits into from
Jan 8, 2022

Conversation

luis-pabon-tf
Copy link
Contributor

Issue

https://otwarchive.atlassian.net/browse/AO3-5754

Purpose

Prevent the minimum length warning overlapping buttons on the home page. The reporter's style suggestion does not affect the inbox version of the notice, so it might be a good way to handle the problem.

Testing Instructions

In the JIRA ticket.

Credit

What name do you want us to use to credit your work in the Archive of Our Own's Release Notes?

bird - (they)

@redsummernight redsummernight changed the title AO3-5754 Implement suggested change to the minimum length warning notice AO3-5754 Fix min-length warning overlapping comment buttons Dec 10, 2019
@luis-pabon-tf luis-pabon-tf deleted the AO3-5754 branch November 14, 2021 20:08
@luis-pabon-tf luis-pabon-tf restored the AO3-5754 branch November 24, 2021 01:02
Adjust LiveValidation margins so the message displays correctly.
@luis-pabon-tf
Copy link
Contributor Author

Very, very late, but I applied the suggested tweaks and it looks better now.

Copy link
Member

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants