Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 2133 with pseud works index displaying user instead of pseud #576

Merged
merged 2 commits into from
Apr 14, 2012
Merged

Fix issue 2133 with pseud works index displaying user instead of pseud #576

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69f8233
Fix issue 2133 with pseud works index displaying user isntead of pseud
sarken Apr 13, 2012
108120d
Fix error when not viewing pseud
sarken Apr 14, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/works/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<% if @collection %>
<%= ts("in %{collection_title}", :collection_title => link_to(@collection.title, @collection)).html_safe %>
<% elsif @user %>
<%= ts("by %{user_name}", :user_name => @user.login) %>
<%= ts("by %{author_name}", :author_name => @author.name) %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is actually going to error, I think - author is always a pseud, so if you're on the user's main works page, it won't be set. (The author variables should really all be renamed to pseud so that this is clearer.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it does, now that I cleared my cache. Let me poke at it some more...

<% elsif @tag %>
<%= ts("in %{tag_name}", :tag_name => @tag.name) %>
<% end %>
Expand Down