Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to skip files ignored by .gitignore #170

Closed
hoodie opened this issue Nov 7, 2021 · 3 comments
Closed

Add flag to skip files ignored by .gitignore #170

hoodie opened this issue Nov 7, 2021 · 3 comments
Milestone

Comments

@hoodie
Copy link

hoodie commented Nov 7, 2021

Hi there!
Very nice tool. I'm wondering, since this is using walkdir I'd assume adding the ignore crate ought to be fairly straight forward. So ouch could have a feature where it automatically ignores certain files/folders like ./.git or ./node_modulesor ./target while compressing.

Would anybody be interested in this functionality?

thank you

@vrmiguel
Copy link
Member

vrmiguel commented Nov 7, 2021

I like that idea :D

We could follow in ripgrep's steps and respect gitignore rules and skip hidden files/directories

@hoodie
Copy link
Author

hoodie commented Nov 7, 2021

yes, exactly. and the cool thing is that you get most of this for free by using ignore afaik

@marcospb19 marcospb19 changed the title RFC: optionally using "ignore" Add flag to skip files ignored by .gitignore Nov 10, 2021
@marcospb19 marcospb19 added this to the 0.4.0 milestone Nov 11, 2021
@marcospb19
Copy link
Member

Fixed at #245 by @vrmiguel 🚀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants