Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressing a single file to a single format that's not tar or zip panics #87

Closed
SpyrosRoum opened this issue Oct 14, 2021 · 4 comments · Fixed by #89
Closed

Compressing a single file to a single format that's not tar or zip panics #87

SpyrosRoum opened this issue Oct 14, 2021 · 4 comments · Fixed by #89
Labels
bug Something isn't working urgent! Highest priority of them all

Comments

@SpyrosRoum
Copy link
Contributor

Hello, I was giving #54 a try when I stumbled on to this.

Running ouch c file file.gz for example panics because it hits an unreachable!():
thread 'main' panicked at 'internal error: entered unreachable code', src/commands.rs:176:18

Is this correct behavior?

@SpyrosRoum SpyrosRoum changed the title Compressing a single file to something that doesn't start with tar or zip panics Compressing a single file to a single format that's not tar or zip panics Oct 14, 2021
@marcospb19
Copy link
Member

marcospb19 commented Oct 14, 2021

That's not intended, that's catastrophic! We for sure need to fix #31 and and this TODO:

/// TODO: test the remaining formats.

Thanks for pointing this out, I need to merge one PR before, and then I'll fix this issue. Will try doing this today that I got some free time.

@marcospb19 marcospb19 added bug Something isn't working high priority labels Oct 14, 2021
@marcospb19 marcospb19 added this to the 0.2.1 milestone Oct 14, 2021
@marcospb19
Copy link
Member

marcospb19 commented Oct 14, 2021

Added to milestone 0.2.1 to remember have to make a new release with this fixed.

@SpyrosRoum
Copy link
Contributor Author

Great, as soon as this is done I can make a pr for 54 :D
I'd help with this but I'm not really sure how you want to handle it

@marcospb19 marcospb19 added urgent! Highest priority of them all and removed high priority labels Oct 14, 2021
@marcospb19
Copy link
Member

If you come across any questions, feel free to ask them in 54, or in a draft pr so I can review and help 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working urgent! Highest priority of them all
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants