Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Smart decompress into a directory #195

Closed
wants to merge 3 commits into from

Conversation

sigmaSd
Copy link
Contributor

@sigmaSd sigmaSd commented Nov 12, 2021

fix #151

This a bit complex and I managed to remove directories unintentionally a couple of times when writing it, so the maintainers needs to judge if this complexity is worth it.

@sigmaSd sigmaSd closed this Nov 12, 2021
@sigmaSd sigmaSd deleted the one_dir branch November 12, 2021 19:55
@sigmaSd sigmaSd restored the one_dir branch November 13, 2021 07:54
@sigmaSd sigmaSd reopened this Nov 13, 2021
@marcospb19
Copy link
Member

Do you have idea why it's failing on Windows? Maybe some tempfile differences stuff?

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Nov 13, 2021

I added an XXX note where the problem is

Rename cant happen between different mount points (like /tmp and /)

Thats why in proptest the tempdir should be created in /tmp but somehow proptest still takes the tempdir_in(".") path and create it in the wrong place

Im not sure whats the real issue I thought proptest should invoke the code under cfg test but it isnt, maybe its a bug

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Nov 13, 2021

Thats whats hapenning on linux, Im guessing its the same issue in windows

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Nov 13, 2021

Maybe a more correct approach is to create the temp directory in the parent folder of the output file instead of hardcoding to "."

I think that would make it work im all cases

@marcospb19
Copy link
Member

Got it, so, I did not had the time to review this properly yet, ouch has been getting a lot of attention and it's hard to keep up.

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Nov 14, 2021

That's a good thing!

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Nov 14, 2021

I'm not sure about the windows test yet

Also there are still some edge cases not handled

@sigmaSd sigmaSd changed the title Smart decompress into a directory [Draft] Smart decompress into a directory Nov 14, 2021
@sigmaSd
Copy link
Contributor Author

sigmaSd commented Nov 15, 2021

Superseded by #209

@sigmaSd sigmaSd closed this Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically decompress the archive into a directory if there is no directory for the contents in the archive
2 participants