Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify decompress function #206

Merged
merged 3 commits into from
Nov 14, 2021
Merged

Simplify decompress function #206

merged 3 commits into from
Nov 14, 2021

Conversation

sigmaSd
Copy link
Contributor

@sigmaSd sigmaSd commented Nov 14, 2021

While working on #195 I felt that there is a lot of complexity in certain part of the code-base

This can be dangerous since ouch manipulates files and directories

This an attempt to simplify decompress function

One thing I would want is if we agree on some terminology and write it somewhere, for example the word file is used everywhere but sometimes it means directories, and I really want a name for single file format archive and the other type, etc

@marcospb19
Copy link
Member

One thing I would want is if we agree on some terminology and write it somewhere, for example the word file is used everywhere but sometimes it means directories, and I really want a name for single file format archive and the other type, etc

I mean, we accept files as input, but directories are files too.

The correct way to differentiate, in my opinion, is that a "file" can be a "regular file" or a "directory".

I used to call those formats "Single file formats", but you can call them "non-archive formats" too, although I think that "single file format archive" that you said does not make sense, they are not archives because archives have support to bundle multiple files inside of it.

I think of it this way: single file formats do not accept directories because they can contain multiple files inside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants