New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check needed for ERC721 interface #8

Closed

iainnash opened this issue Sep 17, 2021 · 1 comment

Contributor

iainnash commented Sep 17, 2021

v3/contracts/modules/ReserveAuction/V1/LibReserveAuctionV1.sol

Line 159 in bacef24

    
           require(IERC165(_tokenContract).supportsInterface(ERC721_INTERFACE_ID), "createAuction tokenContract does not support ERC721 interface");

Given makersplace doesn't properly handle ERC165 plus a few older 721 contracts should we just skip this check?

kulkarohan mentioned this issue

[fix] update approval logic #27

Merged

Contributor

kulkarohan commented Oct 15, 2021

kulkarohan closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment