Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Option to not build/install the executable ouster_client_example #393

Closed
vebjornjr opened this issue Jun 10, 2022 · 2 comments
Closed
Assignees

Comments

@vebjornjr
Copy link

Hey again.

We build and install this library (ouster_client.a) to a folder in our git repo for full control of versions with regards to deployment and such. In such a case it would be useful with a CMake option to not build the executable since we don't want to commit a executable that we don't use into our repo.

If we delete the binary produced, we get CMake errors from:

find_package(OusterSDK 20220608 EXACT CONFIG REQUIRED
    PATHS
        ${PROJECT_SOURCE_DIR}/../../external
)

-- Found OusterSDK: /media/nvidia/ssd/steer/external/lib/cmake/OusterSDK/OusterSDKConfig.cmake
CMake Error at /media/nvidia/ssd/steer/external/lib/cmake/OusterSDK/OusterSDKTargets.cmake:88 (message):
The imported target "OusterSDK::ouster_client_example" references the file

 "/media/nvidia/ssd/steer/external/bin/ouster_client_example"

but this file does not exist. Possible reasons include:

  • The file was deleted, renamed, or moved to another location.

  • An install or uninstall procedure did not complete successfully.

  • The installation package was faulty and contained

    "/media/nvidia/ssd/steer/external/lib/cmake/OusterSDK/OusterSDKTargets.cmake"

but not all the files it references.

@kairenw
Copy link
Contributor

kairenw commented Jun 13, 2022

Yeah, that's not ideal! Thanks for pointing that out. We can probably push out a fix probably this week or next.

Leaving this open till it's addressed. Thanks!

kairenw pushed a commit that referenced this issue Aug 23, 2022
* Address github #349, LICENSE installed to location without prefix
* Update LICENSE format to conform to debian standards
* Finish addressing github #393 by moving the client example
* Fix python/Dockerfile failing to run tox tests due to permission
  errors in the image
* Fix warning in setup.py due to old 'namespace_packages' parameter
* Fix bug preventing CMAKE_CXX_STANDARD selection from working
* Fix FLEETSW-3682 default SDK build crashing in C++17 projects due to
  nonstd::optional compiling differently depending on cxx std
* Fix cmake bug preventing linking curl with cmake 3.10
@kairenw
Copy link
Contributor

kairenw commented Aug 24, 2022

I believe this is addressed by #420. Closing this out.

@kairenw kairenw closed this as completed Aug 24, 2022
@kairenw kairenw self-assigned this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants