Update for FW 3.0/2.5. See changelog for details #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additions: * Add init_logger to control logs emitted by ouster_client * Parsing for FW 3.0/2.5 thermal features * convenience string output functions for LidarScan * new flag for set_config() method to force reinit * improvements to the ouster_viz library Breaking changes: * signal multiplier type changed to double * make_xyz_lut takes mat4d instead of double to handle transformation from beam to lidar frame * drop default parameters from shortform init_client() * drop default parameters of Python client.Sensor() constructor * change Python Scans timeout to default to 1 second instead of None Bug Fixes: * Address processed frame drop when frame_id wraps around
kairenw
force-pushed
the
fw3.0-beta-release
branch
from
1177a29
to
7121cf5
Compare
bexcite
approved these changes
Nov 17, 2022
| 0) { // is an OS-DOME - fill with 0 | ||
| info.lidar_origin_to_beam_origin_mm = 0; | ||
| } else { // not an OS-DOME | ||
| logger().warn("No lidar_origin_to_beam_origin_mm found."); |
Samahu
reviewed
Nov 17, 2022
Samahu
reviewed
Nov 17, 2022
| @@ -9,6 +9,7 @@ | |||
| #include <cmath> | |||
| #include <cstddef> | |||
| #include <cstring> | |||
| #include <iostream> | |||
There was a problem hiding this comment.
[nit] I think sstream should have been sufficient.
There was a problem hiding this comment.
good point, we'll get it on the next one
This was referenced Dec 10, 2022
Closed
kairenw
added a commit
that referenced
this pull request
Mar 29, 2023
Additions: * Add init_logger to control logs emitted by ouster_client * Parsing for FW 3.0/2.5 thermal features * convenience string output functions for LidarScan * new flag for set_config() method to force reinit * improvements to the ouster_viz library Breaking changes: * signal multiplier type changed to double * make_xyz_lut takes mat4d instead of double to handle transformation from beam to lidar frame * drop default parameters from shortform init_client() * drop default parameters of Python client.Sensor() constructor * change Python Scans timeout to default to 1 second instead of None Bug Fixes: * Address processed frame drop when frame_id wraps around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions:
CONFIG_FORCE_REINITfor set_config() method to force reinitBreaking changes:
Bug Fixes: