Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM support #1

Open
jpulik opened this issue Aug 31, 2021 · 5 comments
Open

SPM support #1

jpulik opened this issue Aug 31, 2021 · 5 comments

Comments

@jpulik
Copy link
Contributor

jpulik commented Aug 31, 2021

Hi,
What about adding Swift Package Manager support? SPM now does support binary frameworks.
If you want, I may help you with this.

@pfandrade
Copy link
Member

Hi, I'm not actually using this with SPM in any of my projects. But if you want to make a PR I can review it and merge it.

I guess the OpenSSL.framework should also be SPM enabled for this to work no?

@jpulik
Copy link
Contributor Author

jpulik commented Sep 7, 2021

Thank you for the answer, yes, OpenSSL should support it too.
I will take a look and will create Pull request when there is some time for this.

@pfandrade
Copy link
Member

I've been taking a look at this and have stumbled into an issue. My goal is to distribute this as a binary framework (just like OpenSSL is at moment) but also specify the OpenSSL as a dependency.

Doing this would mean if you specify Noise as a dependency in your project, SwiftPM would also fetch OpenSSL automatically.

However, I don't seem to be able to specify dependencies for binaryTargets. If you have any ideas on this, would love to hear them.

@jpulik
Copy link
Contributor Author

jpulik commented Sep 10, 2021

You are right, it seems like the binary package cannot have any dependencies right now:
https://bugs.swift.org/browse/SR-14245
Maybe possible workaround to try is here:
https://forums.swift.org/t/swiftpm-binary-target-with-sub-dependencies/40197/7

@pfandrade
Copy link
Member

Yes, I actually tried that but ended up encountering a couple of different issues from it. If I have more time I'll give it another go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants