Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with combination of italic and bold #443

Closed
tommoor opened this issue Nov 25, 2017 · 8 comments · Fixed by #1227
Closed

Problems with combination of italic and bold #443

tommoor opened this issue Nov 25, 2017 · 8 comments · Fixed by #1227
Assignees

Comments

@tommoor
Copy link
Member

tommoor commented Nov 25, 2017

Noticed that if you have italic and then bold in the same paragraph the formatting gets broken on save. Amazed I haven't seen this before. Likely because italic uses * and bold **

@tommoor tommoor self-assigned this Nov 25, 2017
@jorilallo
Copy link
Contributor

Interesting. I made changes to this some time ago but it was just to check for trailing/leading whitespace

@tommoor
Copy link
Member Author

tommoor commented Nov 26, 2017

Ah, that probably broke it actually italic + bold = ***blah***

@jorilallo
Copy link
Contributor

hmms, is that even markdown?

@tommoor
Copy link
Member Author

tommoor commented Nov 26, 2017

I was thinking a quick fix would be to use the underline syntax for italic instead. However that would still fail because of the white space rule: _**blah**_

I'm not sure how valid it is technically but we probably want to allow it rather than forcing only one formatting style at a time?

@jorilallo
Copy link
Contributor

I always used ** for bold and _ for italic to make it easier for myself. I think it would be ok to do that in serialization. For markdown shortcuts, I highly doubt anyone does ***, I never seen that

@stale
Copy link

stale bot commented Feb 11, 2018

Hey! The issue has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs. Please reply here if you wish for the issue to be kept open.

@stale stale bot added the stale label Feb 11, 2018
@stale stale bot closed this as completed Feb 18, 2018
@tommoor
Copy link
Member Author

tommoor commented Feb 18, 2018

Should have taken stalebot more seriously 😆

@tommoor
Copy link
Member Author

tommoor commented Jan 22, 2020

Fixed as part of outline/rich-markdown-editor#150

@tommoor tommoor mentioned this issue Apr 7, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants