Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some dependency issues and remove obsolete try-except block #967

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

fpgmaas
Copy link
Contributor

@fpgmaas fpgmaas commented Jun 14, 2024

Since #955 was closed with the reason that there was no interest in adding another step to the CI pipeline, it might still be worthwhile to resolve some issues with the project's dependencies without adding deptry to the project or the CI pipeline. This PR:

  • Removes the obsolete try-except blocks for importing pyairports and pycountry, since they are listed in the project's dependencies.
  • Add the transitive dependency typing_extensions to the dependencies
  • Remove ray as a development dependency

Let me know your thoughts :) Feel free to close if you think it does not bring improvement to the project

@fpgmaas fpgmaas changed the title WIP: Feat/fix deps Fix some dependency issues and remove obsolete try-except block. Jun 14, 2024
pyproject.toml Outdated Show resolved Hide resolved
@fpgmaas fpgmaas changed the title Fix some dependency issues and remove obsolete try-except block. Fix some dependency issues and remove obsolete try-except block Jun 14, 2024
@lapp0
Copy link
Contributor

lapp0 commented Jun 14, 2024

@rlouf do many users use Outlines in a way which doesn't require torch? The only models which don't require torch AFAIK are models.llamacpp, models.mlxlm and models.openai.

@fpgmaas Could you rebase and squash this to one or two commits?

Edit: sorry, wrong remi

@fpgmaas
Copy link
Contributor Author

fpgmaas commented Jun 15, 2024

@remic33 do many users use Outlines in a way which doesn't require torch? The only models which don't require torch AFAIK are models.llamacpp, models.mlxlm and models.openai.

@fpgmaas Could you rebase and squash this to one or two commits?

done!

@rlouf
Copy link
Member

rlouf commented Jun 15, 2024

torch is a really big dependency and I would rather not force it on people who don’t need it; especially libraries that import outlines just for the FSM logic (vLLM, etc)

@rlouf
Copy link
Member

rlouf commented Jun 15, 2024

Thanks for contributing @fpgmaas ! Merging.

@rlouf rlouf merged commit 502bfdd into dottxt-ai:main Jun 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants