Skip to content
This repository has been archived by the owner on Apr 20, 2019. It is now read-only.

Hapi 13 peerDependencies Support? #29

Closed
bflad opened this issue Jun 8, 2016 · 4 comments
Closed

Hapi 13 peerDependencies Support? #29

bflad opened this issue Jun 8, 2016 · 4 comments
Milestone

Comments

@bflad
Copy link

bflad commented Jun 8, 2016

Hi, we were hoping to upgrade from Hapi 11 to 13 and receive the following error running npm install:

npm ERR! Darwin 15.5.0
npm ERR! argv "/Users/bflad/.nvm/versions/node/v4.4.1/bin/node" "/Users/bflad/.nvm/versions/node/v4.4.1/bin/npm" "install"
npm ERR! node v4.4.1
npm ERR! npm  v2.14.20
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package hapi@13.4.1 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer reptile@2.1.1 wants hapi@>=11.x.x

The peerDependencies are currently too strict to support both 11 and 13:

"peerDependencies": {
  "hapi": ">=11.x.x"
},

I noticed you already have 13.x.x in the devDependencies, are you planning on cutting a release with 13 support? Please let me know if you need any help testing or upgrading. Thanks!

@geek geek added the dependency label Jun 8, 2016
@geek geek added this to the 2.1.2 milestone Jun 8, 2016
@geek geek self-assigned this Jun 8, 2016
@geek geek closed this as completed in #30 Jun 8, 2016
@geek
Copy link
Contributor

geek commented Jun 8, 2016

@bflad you should be good to go... I also made the package size smaller.

@bflad
Copy link
Author

bflad commented Jun 8, 2016

Thank you!

@devinivy
Copy link
Contributor

devinivy commented Jun 8, 2016

@geek I don't think this was an issue. 13.x.x satisfies >=11.x.x, but one of my apps on hapi v11 becomes sad when pulling in this change due to a peer dep error.

@bflad
Copy link
Author

bflad commented Jun 8, 2016

Interestingly enough, NPM was listing all modules with hapi as a peer dependency for these peerDependencies errors. Another module updated its dependency from ~11.x.x to allow both 11 and 13, then without upgrading this module, NPM was happy. It looks like >=11.x.x should actually work for 11 and 13. I'm really sorry for the confusion here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants