MaxTotalIOPS over Outscale's limit

[pavloos]

/kind bug

What happened?
Maximum IOPS is higher than 13000 allowed by Outscale

As a result IOPS are trimmed down to 20000 and request fails - API access logs shows the request created with iopsPerGB: 300 and PVC of 100Gi

    "Logs": [
        {
            "ResponseStatusCode": 400,
            "ResponseSize": 143,
            "QueryPayloadRaw": "{\"Iops\":20000,\"Size\":100,\"SubregionName\":\"cloudgouv-eu-west-1a\",\"VolumeType\":\"io1\"}\n",
            "AccountId": "XXX",
            "QueryUserAgent": "osc-bsu-csi-driver/v1.0.0",
            "CallDuration": 34,
            "RequestId": "0b5b0926-ad14-4809-8afa-e18350e43de5",
            "QueryApiVersion": "1.22",
            "QueryIpAddress": "1.2.3.4",
            "QueryApiName": "oapi",
            "QueryPayloadSize": 84,
            "QueryCallName": "CreateVolume",
            "QueryAccessKey": "XXX",
            "QueryHeaderSize": 351,
            "QueryDate": "2022-10-04T10:11:55.587546Z",
            "QueryHeaderRaw": "Host: api.cloudgouv-eu-west-1.outscale.com\\nAccept: application/json\\nConnection: close\\nUser-Agent: osc-bsu-csi-driver/v1.0.0\\nX-Amz-Date: 20221004T101155Z\\nX-SSL-CERT: -----BEGIN CERTIFICATE----------END CERTIFICATE-----\\nContent-Type: application/json\\nAuthorization: *****\\nContent-Length: 84\\nAccept-Encoding: gzip\\nX-Forwarded-For: 1.2.3.4"
        },

What you expected to happen?
Controller to scale down IOPS to maximum allowed value and create a volume

How to reproduce it (as minimally and precisely as possible)?

allowVolumeExpansion: true
allowedTopologies:
  - matchLabelExpressions:
      - key: topology.bsu.csi.outscale.com/zone
        values:
          - cloudgouv-eu-west-1a
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: osc-io1-big
parameters:
  iopsPerGB: "300"
  type: io1
provisioner: bsu.csi.outscale.com
reclaimPolicy: Delete
volumeBindingMode: Immediate
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: block-claim
spec:
  accessModes:
    - ReadWriteOnce
  volumeMode: Block
  storageClassName: osc-io1-big
  resources:
    requests:
      storage: 100Gi

Anything else we need to know?:

Environment

• Kubernetes version (use kubectl version):
  Server Version: v1.23.10+rke2r1

• Driver version:
  v1.0.0

[jerome-jutteau]

Hi @pavloos, thanks for pointing out the issue and proposing a PR. We will also add an additional test to avoid this issue in the future.