Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bun --filter removes ANSI colors from certain output #10346

Open
Cygnusfear opened this issue Apr 18, 2024 · 5 comments
Open

bun --filter removes ANSI colors from certain output #10346

Cygnusfear opened this issue Apr 18, 2024 · 5 comments
Labels
bug Something isn't working bun install Something that relates to the npm-compatible client

Comments

@Cygnusfear
Copy link

What version of Bun is running?

1.1.4+fbe2fe0c3

What platform is your computer?

No response

What steps can reproduce the bug?

Run anything with --filter

What is the expected behavior?

Output has colors!

What do you see instead?

It's all grey with a cyan line to the left

Additional information

--filter rocks tho 🙏

@Cygnusfear Cygnusfear added the bug Something isn't working label Apr 18, 2024
@Cygnusfear Cygnusfear changed the title bun --filter removes ANSII colors from output bun --filter removes ANSI colors from output Apr 18, 2024
@Cygnusfear Cygnusfear changed the title bun --filter removes ANSI colors from output bun --filter removes ANSI colors from certain output Apr 18, 2024
@Cygnusfear Cygnusfear reopened this Apr 18, 2024
@Electroid Electroid added the bun install Something that relates to the npm-compatible client label Apr 18, 2024
@Electroid
Copy link
Contributor

@gvilums Any ideas on this one?

@Jarred-Sumner
Copy link
Collaborator

Since we use sockets the process on the other end realizes no colors so we should probably force it to use colors anyway via FORCE_COLORS env var. we should look at the env vars we pass through too to make sure it’s consistent with bun run

@aralroca
Copy link
Contributor

aralroca commented Apr 18, 2024

Also related with --filter I see that with bun run --filter 'my-package-1' --filter 'my-package-2' test the GitHub action does not detect when it fails and goes green even if tests fail

@Jarred-Sumner
Copy link
Collaborator

@aralroca can you file an issue for this?

@aralroca
Copy link
Contributor

Done #10359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bun install Something that relates to the npm-compatible client
Projects
None yet
Development

No branches or pull requests

4 participants