Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer date #63

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Conversation

CodeWithEmad
Copy link
Member

@CodeWithEmad CodeWithEmad commented Feb 18, 2024

This will:

  • fix the hardcoded year in the footer.
  • Update the URL of tutor docs.
  • A new screenshot inside README.
  • Cleanup in README.rst (correct Open edX URL and mako code highlighting)

Close #62 #64

@CodeWithEmad
Copy link
Member Author

also, Add issue and bugs to project fails because:
Error: Input required and not supplied: github-token
@regisb @hinakhadim

- openedx URL fixed
- code block used for mako for a better code highlighting
@misilot
Copy link
Contributor

misilot commented Feb 19, 2024

I don't think this will fix the hard coded date on the MFE apps domain (and others?)

https://apps.sandbox.openedx.edly.io/learner-dashboard/

@CodeWithEmad
Copy link
Member Author

I don't get it. Why not?

@misilot
Copy link
Contributor

misilot commented Feb 19, 2024

At least from what I am seeing is the Apps MFE does not inherit settings from Indigo, though it uses parts of it (like links to the logos) such as the color or footer settings. Maybe it's something broken with my forked theme, but it is something to check.

@misilot
Copy link
Contributor

misilot commented Feb 19, 2024

@hinakhadim
Copy link
Collaborator

Thanks for the PR. Let me make sure, everything is working for merging. Also, It won't update the MFE footer year because it's hard-coded in MFE footer.

@CodeWithEmad
Copy link
Member Author

CodeWithEmad commented Feb 20, 2024

You're right, @misilot. It won't fix the hardcoded year in the learner dashboard mfe. I didn't notice the new changes in Quince:
RUN npm install '@edx/frontend-component-footer@npm:@edly-io/indigo-frontend-component-footer@^1.0.0'
and only checked the https://github.com/openedx/frontend-component-footer, couldn't find any hardcoded thing there and suspected the indigo theme somehow.
Is there any documentation about the new changes coming from edly-io? @hinakhadim @regisb

@hinakhadim
Copy link
Collaborator

@CodeWithEmad There is no documentation of new changes related to indigo-footer. Let me add this to my to-do list.

@hinakhadim
Copy link
Collaborator

hinakhadim commented Feb 26, 2024

@CodeWithEmad Thanks for the PR. Great Work!

@hinakhadim hinakhadim merged commit b4e4110 into overhangio:master Feb 26, 2024
1 check passed
@CodeWithEmad CodeWithEmad deleted the fix/footer-date branch February 26, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Copyright Year hard-coded to 2023
3 participants