Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing "?" and "=" from default output file name when fetching url #459

Closed
wants to merge 1 commit into from

Conversation

raggaraluz
Copy link

This one fixes #458

@plexus
Copy link
Contributor

plexus commented Nov 3, 2023

The original issue (#458) is that when fetching a url like https://www.freesound.org/apiv2/sounds/2086/?format=json, it tries to save a file name ?format=json, which fails on Windows. This PR would change that to formatjson (I think?).

I haven't looked at this too deeply, but it looks like asset-path tries to find the last path segment (split on /). would it make more sense to drop any query params first, so that asset-path would save the above URL as 2086?

@plexus
Copy link
Contributor

plexus commented Nov 3, 2023

It looks like this has actually been fixed #487, so I'm going to close this. Feel free to reopen or open a new issue if this turns out to still be an issue. Thank you @raggaraluz for the patch!

@plexus plexus closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error using freesound-path in windows
2 participants