Fix window paths to allow downloading samples #487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses issue #486 and allows me to use the sampled-piano on windows.
The files end up being stored in weird places. For example sample 148530 ends up as a wav file store here:
PIANO_LOUD_DB5.wav
and a json file that describes it store in another directory
~/.overtone/assets/freesound.org-apiv2-sounds-148530-formatjson---4716015:
148530
Looking at the code, I think the same weirdness happens in linux too with the current version.