Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0.0] PHAR version not available #175

Closed
llaville opened this issue Feb 13, 2023 · 6 comments
Closed

[9.0.0] PHAR version not available #175

llaville opened this issue Feb 13, 2023 · 6 comments
Assignees
Labels

Comments

@llaville
Copy link
Collaborator

Summary

Release workflow did not build the PHAR version of PHPLint 9.0.0
(https://github.com/overtrue/phplint/actions/runs/4162210510/jobs/7201105513)

Expected behaviour

PHAR built

Actual behaviour

PHAR version not available

@llaville llaville added the bug label Feb 13, 2023
@llaville llaville self-assigned this Feb 13, 2023
llaville added a commit that referenced this issue Feb 13, 2023
@llaville
Copy link
Collaborator Author

llaville commented Feb 13, 2023

@overtrue I've a permission denied https://github.com/overtrue/phplint/actions/runs/4164613643/jobs/7206478202#step:7:21 when create a new release (with release workflows).
Could you check-in and give me your feedback please ?

PHAR build was fixed; It's on upload process !

@overtrue
Copy link
Owner

I just tried to re-run it and also reported the same error, the logs are as follows.

https://github.com/overtrue/phplint/actions/runs/4164613643/jobs/7206478202#step:7:21

Is it because the path to the .phar file is not the right value?

Build:

Building the PHAR "/github/workspace/bin/phplint.phar"

Publish:

Error: EACCES: permission denied, open '/home/runner/work/phplint/phplint/bin/phplint.phar'

@llaville
Copy link
Collaborator Author

@overtrue At the Build PHAR step inside line 10 (initialisation) we can find -v "/home/runner/work/phplint/phplint":"/github/workspace"

I'm convainced that the volume is propagated (because read-write by default) : https://docs.docker.com/storage/volumes/#populate-a-volume-using-a-container

But it should not be !

@llaville
Copy link
Collaborator Author

@overtrue I'll replace current https://github.com/overtrue/phplint/blob/9.0.2/.github/workflows/build-phar.yml workflow, by the new one https://github.com/overtrue/phplint/blob/main/.github/workflows/release.yml

PS: I've replaced my docker image that produce PHAR artifact in root mode, by invocation of the box-manifest PHAR version

Advantage:

  • Automation to prepare (write) new release with CHANGELOG fragment corresponding to version. Gave something like

github com_overtrue_phplint_releases_tag_untagged

  • We ca run it manually (see workflow_dispatch)

release-workflow

NOTE The draft mode (checkbox on workflow dispatch dialog box) when enable allow a chance to preview/modify before publish it definitively !

@llaville
Copy link
Collaborator Author

FYI: I'll clean-up repository, due to all my tests in few minutes, and publish the new release 9.0.3

@llaville
Copy link
Collaborator Author

@overtrue FYI :
I've played a bit with new workflow, but PHAR distribution is now available.
I'll close this report, but I need to improve the new https://github.com/overtrue/phplint/blob/9.0.3/.github/workflows/release.yml for next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants