Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Symfony 7 support #196

Closed
sukhwinder33445 opened this issue Dec 1, 2023 · 3 comments
Closed

Better Symfony 7 support #196

sukhwinder33445 opened this issue Dec 1, 2023 · 3 comments
Assignees
Labels

Comments

@sukhwinder33445
Copy link

sukhwinder33445 commented Dec 1, 2023

New Issue

PHP Fatal error: Declaration of Overtrue\PHPLint\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /home/runner/work/My_Module/vendor/overtrue/phplint/src/Console/Application.php on line 50

Diagnose

Installed with : Run composer require -n --no-progress overtrue/phplint
Version: (9.0.5)
PhpVersion: > 8.1

@sukhwinder33445 sukhwinder33445 changed the title Declaration of PHPLint#Console\Application::doRun() must be compatible with Symfony#Component\Console\Application::doRun() Declaration of PHPLint#Console\Application::doRun() must be compatible with Symfony#Component\Console\Application::doRun() Dec 1, 2023
sukhwinder33445 added a commit to Icinga/icingaweb2-module-director that referenced this issue Dec 1, 2023
@llaville
Copy link
Collaborator

llaville commented Dec 2, 2023

Related to PR #195. Allowing Symfony 7 components depencencies by Composer constraint was not enough to add full support to SF 7.
Especially because SF components signature has changed by adding return type hint.

This is the reason while it does not works on PHP 8.2 and 8.3 that install Symfony v7.0 component,
and while it works fine on PHP 8.1 that still install Symfony v6.4 components (signature compatible).

@llaville llaville self-assigned this Dec 2, 2023
@llaville llaville added the bug label Dec 2, 2023
@llaville llaville changed the title Declaration of PHPLint#Console\Application::doRun() must be compatible with Symfony#Component\Console\Application::doRun() Better Symfony 7 support Dec 2, 2023
llaville added a commit that referenced this issue Dec 2, 2023
@llaville
Copy link
Collaborator

llaville commented Dec 2, 2023

Tested locally, without to re-publish a new version by setting a dev environment such as :

{
    "repositories": [
        {
            "type": "path",
            "url": "../github/phplint"
        }
    ],
    "require": {
        "overtrue/phplint": "9.0.x-dev"
    },
    "minimum-stability": "dev"
}

Tests realized on PHP 8.1.26, 8.2.13, 8.3.0 without detecting any new issues.

Bugfix release 9.0.6 is on way !

@llaville
Copy link
Collaborator

llaville commented Dec 2, 2023

v9.0.6 is now available

@llaville llaville closed this as completed Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants