Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): config env #3230

Merged
merged 7 commits into from
Aug 21, 2018
Merged

fix(engine): config env #3230

merged 7 commits into from
Aug 21, 2018

Conversation

yesnault
Copy link
Member

No description provided.

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault yesnault requested a review from bnjjj August 20, 2018 21:15
@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 20, 2018

CDS Report it#5644.0 ✘

  • w-it
    • w-it ✘

engine/main.go Outdated
conf.Debug = &DebugConfiguration{}
}
configBootstrap(args)
config(args)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In config you already call configBootstrap. I don’t understand why do you call this twice

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 21, 2018

CDS Report it#5648.0 ✘

  • w-it
    • w-it ✘

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 21, 2018

CDS Report it#5651.0 ✘

  • w-it

    • w-it ✘
      Unit Tests Report
  • Platform model admin [tests/cli_admin_platform_model.yml]

  • Application Command TestSuite [tests/cli_application.yml]

  • Environment Command TestSuite [tests/cli_environment.yml]

  • Pipeline Command TestSuite [tests/cli_pipeline.yml]

  • Pipeline Export / Import Command TestSuite [tests/cli_pipeline_export_import.yml]

  • Action Command TestSuite with cdsctl [tests/clictl_action.yml]

  • Broadcast Command TestSuite [tests/clictl_admin_broadcast.yml]

  • Plugins Command TestSuite with cdsctl [tests/clictl_admin_plugin_and_platforms.yml]

  • Action Command TestSuite with cdsctl [tests/clictl_admin_services.yml]

    • cdsctl admin services list ✘
  • Application Command TestSuite with CDS ctl [tests/clictl_application.yml]

  • Environement Command TestSuite with CDS ctl [tests/clictl_environment.yml]

  • Group Command TestSuite [tests/clictl_group.yml]

  • Pipeline Command TestSuite with CDS ctl [tests/clictl_pipeline.yml]

  • Project Command TestSuite with CDS ctl [tests/clictl_project.yml]

  • Token Command TestSuite with CDS ctl [tests/clictl_token.yml]

  • User Command TestSuite [tests/clictl_user.yml]

  • Version Command TestSuite [tests/clictl_version.yml]

  • Worker Command TestSuite [tests/clictl_worker_model.yml]

  • Create a simple workflow (ITSCWRKFLW3) and run it [tests/sc_workflow_create_run_join.yml]

  • Create a simple workflow (ITSCWRKFLW1) and pull it [tests/sc_workflow_create_simple.yml]

  • Create a simple workflow (ITSCWRKFLW6) and run it to test gitClone action [tests/sc_workflow_git_clone_tag.yml]

    • check workflow ✘
  • Workflow (ITSCWRKFLW5) should use the worker key install command [tests/sc_workflow_key_install.yml]

    • the workflow should be successfull ✘
  • Workflow (ITSCWRKFLW4) should use the worker cache command [tests/sc_workflow_run_cache.yml]

    • the workflow should be successfull ✘
  • Create a simple workflow (ITSCWRKFLW2) and run it [tests/sc_workflow_run_simple.yml]

  • Create a simple workflow (ITSCWRKFLW2) run it and then stop it [tests/sc_workflow_stop_simple.yml]

  • Create a simple workflow (ITSCWRKFLW2), update it and run it [tests/sc_workflow_update_run.yml]

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@bnjjj bnjjj merged commit 755016c into master Aug 21, 2018
@yesnault yesnault deleted the ye-config-env branch August 22, 2018 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants