Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api,ui): add custom step name #3259

Merged
merged 3 commits into from
Aug 24, 2018
Merged

feat(api,ui): add custom step name #3259

merged 3 commits into from
Aug 24, 2018

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Aug 24, 2018

close #1408
Signed-off-by: Benjamin Coenen benjamin.coenen@corp.ovh.com

  1. Description
    and inside a fix on workflow tag to not tag a branch if we specified tag and branch at the same time
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@bnjjj
feat(api,ui): add custom step name
f304071 
close #1408
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@bnjjj bnjjj added the feature label Aug 24, 2018
@bnjjj bnjjj requested a review from yesnault August 24, 2018 14:15
golangci
golangci reviewed Aug 24, 2018
View reviewed changes
engine/api/pipeline/pipeline_action.go Outdated
query := `UPDATE pipeline_action set action_id=$1, pipeline_stage_id=$2, enabled=$4 WHERE id=$3`
_, err = db.Exec(query, job.Action.ID, job.PipelineStageID, job.PipelineActionID, job.Enabled)
if err != nil {
if UpdatePipelineAction(db, *job); err != nil {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error return value of UpdatePipelineAction is not checked

@bnjjj
feat(api,ui): add custom step name
e759968 
close #1408
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 24, 2018

CDS Report ut-engine#5711.0 ✘

  • Stage 1

    • Engine Test with DB ✘
      Unit Tests Report

  • github.com/ovh/cds/cli

  • github.com/ovh/cds/engine/api

    • Test_putWorkflowHandler ✘

  • github.com/ovh/cds/engine/api/application

  • github.com/ovh/cds/engine/api/environment

  • github.com/ovh/cds/engine/api/keys

  • github.com/ovh/cds/engine/api/migrate

  • github.com/ovh/cds/engine/api/pipeline

  • github.com/ovh/cds/engine/api/plugin

  • github.com/ovh/cds/engine/api/project

  • github.com/ovh/cds/engine/api/secret

  • github.com/ovh/cds/engine/api/user

  • github.com/ovh/cds/engine/api/warning

  • github.com/ovh/cds/engine/api/worker

  • github.com/ovh/cds/engine/api/workflow

  • github.com/ovh/cds/engine/hatchery/swarm

  • github.com/ovh/cds/engine/hooks

  • github.com/ovh/cds/engine/repositories

  • github.com/ovh/cds/engine/vcs

  • github.com/ovh/cds/engine/vcs/bitbucket

  • github.com/ovh/cds/engine/vcs/github

  • github.com/ovh/cds/engine/vcs/gitlab

  • github.com/ovh/cds/engine/worker

  • github.com/ovh/cds/sdk

  • github.com/ovh/cds/sdk/exportentities

  • github.com/ovh/cds/sdk/interpolate

  • github.com/ovh/cds/sdk/luascript

  • github.com/ovh/cds/sdk/plugin/dummy/caller

  • github.com/ovh/cds/sdk/vcs/git

@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 24, 2018

CDS Report ut-engine#5711.1 ✘

  • Stage 1

    • Engine Test with DB ✘
      Unit Tests Report

  • github.com/ovh/cds/cli

  • github.com/ovh/cds/engine/api

    • Test_getWorkflowHandler_withUsage ✘

  • github.com/ovh/cds/engine/api/application

  • github.com/ovh/cds/engine/api/environment

  • github.com/ovh/cds/engine/api/keys

  • github.com/ovh/cds/engine/api/migrate

  • github.com/ovh/cds/engine/api/pipeline

  • github.com/ovh/cds/engine/api/plugin

  • github.com/ovh/cds/engine/api/project

  • github.com/ovh/cds/engine/api/secret

  • github.com/ovh/cds/engine/api/user

  • github.com/ovh/cds/engine/api/warning

  • github.com/ovh/cds/engine/api/worker

  • github.com/ovh/cds/engine/api/workflow

  • github.com/ovh/cds/engine/hatchery/swarm

  • github.com/ovh/cds/engine/hooks

  • github.com/ovh/cds/engine/repositories

  • github.com/ovh/cds/engine/vcs

  • github.com/ovh/cds/engine/vcs/bitbucket

  • github.com/ovh/cds/engine/vcs/github

  • github.com/ovh/cds/engine/vcs/gitlab

  • github.com/ovh/cds/engine/worker

  • github.com/ovh/cds/sdk

  • github.com/ovh/cds/sdk/exportentities

  • github.com/ovh/cds/sdk/interpolate

  • github.com/ovh/cds/sdk/luascript

  • github.com/ovh/cds/sdk/plugin/dummy/caller

  • github.com/ovh/cds/sdk/vcs/git

@bnjjj
feat(api,ui): add custom step name
3608433 
Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@yesnault yesnault merged commit a209ade into master Aug 24, 2018
@bnjjj bnjjj deleted the feat_1408 branch October 10, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangci golangci golangci left review comments

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature idea - add a title/descriptive optional field to job steps and display it in the build logs.
4 participants
@bnjjj @ovh-cds @yesnault @golangci