feat(api,ui): add labels to categorize workflows #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close #3193 Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
golangci
reviewed
Aug 31, 2018
engine/api/project.go
Outdated
| if errTx != nil { | ||
| return sdk.WrapError(errTx, "putProjectLabelsHandler> Cannot create transaction") | ||
| } | ||
| defer tx.Rollback() |
There was a problem hiding this comment.
Error return value of tx.Rollback is not checked
engine/api/workflow.go
Outdated
| if errTx != nil { | ||
| return sdk.WrapError(errTx, "postWorkflowLabelHandler> Cannot create new transaction") | ||
| } | ||
| defer tx.Rollback() |
There was a problem hiding this comment.
Error return value of tx.Rollback is not checked
sguiheux
requested changes
Aug 31, 2018
engine/api/workflow/dao_label.go
Outdated
|
|
||
| "github.com/go-gorp/gorp" | ||
| "github.com/lib/pq" | ||
| "github.com/ovh/cds/engine/api/database" |
engine/sql/125_workflow_label.sql
Outdated
| @@ -0,0 +1,21 @@ | |||
| -- +migrate Up | |||
| CREATE TABLE IF NOT EXISTS workflow_label ( | |||
There was a problem hiding this comment.
project_label lay be a better choice
sdk/workflow.go
Outdated
| } | ||
| label.Color = "#" + hex.EncodeToString(bytes) | ||
| } else { | ||
| if !regexp.MustCompile(`^#\w{3,8}$`).Match([]byte(label.Color)) { |
There was a problem hiding this comment.
regexp.MustCompile(^#\w{3,8}$) . must be done once
| @@ -0,0 +1,3 @@ | |||
| .labels-edit { | |||
There was a problem hiding this comment.
No I prefer keep this format even if it's empty
close #3193 Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
sguiheux
approved these changes
Aug 31, 2018
yesnault
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close Categorize workflows #3193
Unit tests
cc @blaryjp
@ovh/cds