Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hooks infos #3314

Merged
merged 17 commits into from
Sep 19, 2018
Merged

Improve hooks infos #3314

merged 17 commits into from
Sep 19, 2018

Conversation

richardlt
Copy link
Member

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@richardlt richardlt changed the title (WIP) Improve hooks infos WIP Improve hooks infos Sep 11, 2018
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 11, 2018

CDS Report build-engine-cli-tools#5894.0 ✘

  • Build minimal
    • cds cli legacy ✔
    • cdsctl linux ✔
    • Engine Build linux amd64 ✔
    • tools/debpacker ✘
    • tools/os-ansible-inventory ✔
    • Worker linux amd64 / 386 ✔

sguiheux
sguiheux approved these changes Sep 12, 2018
View reviewed changes
engine/api/router_util.go Outdated
return false
}

func SortCompareInt(i, j int, o SortOrder) bool {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 14, 2018

CDS Report ut-engine#5949.0 ✘

  • Stage 1
    • Engine Test with DB ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 14, 2018

CDS Report build-ui#5961.0 ✘

  • Compile

    • Build UI ✔
    • TU All -
    • TU model ✔
    • TU service ✘
    • TU shared ✔
    • TU views ✔
      Unit Tests Report

  • HeadlessChrome 0.0.0 (Linux 0.0.0)

  • HeadlessChrome 0.0.0 (Linux 0.0.0).2016691

    • CDS: pipeline Store should add/update/delete a parameter ✘

  • HeadlessChrome 0.0.0 (Linux 0.0.0).2016693

  • HeadlessChrome 0.0.0 (Linux 0.0.0).2016692

@richardlt richardlt changed the title WIP Improve hooks infos Improve hooks infos Sep 14, 2018
bnjjj
bnjjj suggested changes Sep 17, 2018
View reviewed changes
ui/src/app/shared/table/sorted-table.html Outdated
</tr>
</tbody>
<tbody *ngIf="!loading && data.length > 0">
<tr *ngFor="let d of getDataForCurrentPage()">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to not call function in template

ui/src/app/views/admin/hooks-tasks/details/hooks-task.component.ts Outdated
name: '',
selector: d => {
if (d.status === HookStatus.DONE) {
return '<i class="check green icon"></i>';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel very comfortable with the fact that we write HTML in typescript. Maybe we can find a better way to do this kind of code ?

ui/src/app/views/admin/hooks-tasks/hooks-tasks.component.ts Outdated
<Column>{
type: ColumnType.HTML,
name: '',
selector: d => d.stopped ? '<i class="stop red icon"></i>' : '<i class="play green icon"></i>',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

ui/src/assets/i18n/fr.json Outdated
"hook_task_cron": "CRON",
"hook_task_execs_todo": "Exécutions planifiées",
"hook_task_execs_total": "Total des exécutions",
"hook_task_repo_fullname": "Nom du repository",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/repository/dépôt

fsamin
fsamin requested changes Sep 17, 2018
View reviewed changes
engine/hooks/hooks_handlers.go Outdated
@@ -146,28 +146,62 @@ func (s *Service) postTaskHandler() service.Handler {
}
}

const (
sortKeyNbExecutionsTotal string = "nb_executions_total"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to specify the type

@richardlt
Copy link
Member Author

I removed the HTML column type and created a Icon one. I also add optional filter to the table component and used it hook tasks page.

bnjjj
bnjjj suggested changes Sep 18, 2018
View reviewed changes
ui/src/app/shared/table/data-table.html Outdated
@@ -16,17 +25,19 @@
</td>
</tr>
</tbody>
<tbody *ngIf="!loading && data.length == 0">
<tbody *ngIf="!loading && dataForCurrentPage.length == 0">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strict equals ===

@bnjjj bnjjj merged commit 2583088 into master Sep 19, 2018
@fsamin fsamin deleted the feat-improve-hooks-infos branch November 15, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@sguiheux sguiheux sguiheux approved these changes

@bnjjj bnjjj bnjjj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@richardlt @ovh-cds @yesnault @fsamin @sguiheux @bnjjj