Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): merge pipeline parameter and default value in workflow context #3413

Merged
merged 2 commits into from
Oct 9, 2018

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Oct 8, 2018

Signed-off-by: Benjamin Coenen benjamin.coenen@corp.ovh.com

  1. Description
  2. Related issues
    close pipeline parameter and default value #3380
  3. About tests
  4. Mentions

@ovh/cds

Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
sdk/parameter.go Outdated
@@ -175,6 +175,17 @@ func variablesToParameters(prefix string, variables []Variable) []Parameter {
return res
}

// ParameterspMerge merges two slices of parameters preserving all values
func ParametersMerge(src []Parameter, dst []Parameter) []Parameter {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not really a src / dst, overwritter?

Signed-off-by: Benjamin Coenen <benjamin.coenen@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Oct 8, 2018

CDS Report ut-engine#6398.0 ✘

  • Stage 1

    • Engine Test with DB ✘
      Unit Tests Report
  • github.com/ovh/cds/cli

  • github.com/ovh/cds/engine/api

    • Test_postAndDeleteWorkflowLabelHandler ✘
  • github.com/ovh/cds/engine/api/application

  • github.com/ovh/cds/engine/api/environment

  • github.com/ovh/cds/engine/api/keys

  • github.com/ovh/cds/engine/api/migrate

  • github.com/ovh/cds/engine/api/pipeline

  • github.com/ovh/cds/engine/api/plugin

  • github.com/ovh/cds/engine/api/project

  • github.com/ovh/cds/engine/api/secret

  • github.com/ovh/cds/engine/api/user

  • github.com/ovh/cds/engine/api/warning

  • github.com/ovh/cds/engine/api/worker

  • github.com/ovh/cds/engine/api/workflow

  • github.com/ovh/cds/engine/hatchery/swarm

  • github.com/ovh/cds/engine/hooks

  • github.com/ovh/cds/engine/repositories

  • github.com/ovh/cds/engine/vcs

  • github.com/ovh/cds/engine/vcs/bitbucket

  • github.com/ovh/cds/engine/vcs/github

  • github.com/ovh/cds/engine/vcs/gitlab

  • github.com/ovh/cds/engine/worker

  • github.com/ovh/cds/sdk

  • github.com/ovh/cds/sdk/cdsclient

  • github.com/ovh/cds/sdk/exportentities

  • github.com/ovh/cds/sdk/interpolate

  • github.com/ovh/cds/sdk/luascript

  • github.com/ovh/cds/sdk/namesgenerator

  • github.com/ovh/cds/sdk/vcs/git

@yesnault yesnault merged commit be05fef into master Oct 9, 2018
@bnjjj bnjjj deleted the fix_3380 branch October 10, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipeline parameter and default value
5 participants