Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(processor): YAML syntax error ignored #234

Closed
youen opened this issue Mar 17, 2020 · 2 comments · Fixed by #274
Closed

bug(processor): YAML syntax error ignored #234

youen opened this issue Mar 17, 2020 · 2 comments · Fixed by #274

Comments

@youen
Copy link

youen commented Mar 17, 2020

Hi,

Hi, when I run venom against a list of testsuite files with one file not well formatted, the syntax error is ignored and venom returns a success.

I create two TestSuite files:

MyBadTestSuite.yml

name: Title of TestSuite
testcases:
- name: TestCase with default value, exec cmd. Check if exit code != 1
  steps:
    - script: echo 'foo'
    type: exec

and MyGoodTestSuite.yml

name: Title of TestSuite
testcases:
- name: TestCase with default value, exec cmd. Check if exit code != 1
  steps:
  - script: echo 'foo'
    type: exec

if i run venom with a single file the behaviour is correct.

$ venom run MyBadTestSuite.yml
FATA[0000] yaml: line 5: did not find expected '-' indicator 
$ venom run MyGoodTestSuite.yml 
SUCCESS MyGoodTestSuite.yml                            1.264392ms

Total:1 Duration:1.823555ms
OK:1
KO:0
Skipped:0
TestSuite:1
TestCase:1

However, when I run with these two files no errors and no warning are yielding.

$ venom run MyBadTestSuite.yml MyGoodTestSuite.yml
SUCCESS MyGoodTestSuite.yml                            1.171967ms

Total:1 Duration:1.861674ms
OK:1
KO:0
Skipped:0
TestSuite:1
TestCase:1

I try with the branch master (c1d7719 - feat(dbfixtures): add skipResetSequences parameter) without success.

@youen
Copy link
Author

youen commented Mar 17, 2020

Ok my pull request is a revert of 135b029 - feat: skip invalid venom testsuites instead of return error.

So my bug was a feature 6 month ago 😄

@alexisvisco
Copy link

Up

yesnault added a commit that referenced this issue Oct 7, 2020
Users have to filter the yml files given to venom if needed

close #234
close #235

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
yesnault added a commit that referenced this issue Oct 7, 2020
Users have to filter the yml files given to venom if needed

close #234
close #235

Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants