fix(process): don't ignore invalid venom testsuites #234

[youen]

close #234

[yesnault]

HI @youen

Thank you for this pull request.

We want to keep the existing behaviour as the default behaviour, as some people use some fixtures in yml format, not valid with venom, in the same directory as the test file.

But, it should be great to add a flag as --disabled-yml-check (so with the default setted to false).

[alexispiaud]

I have the same issue. We realise to late if we have a mistake in our yml file

[alexisvisco]

This PR should be reviewed because it's a critical bug which leads to not tested files.

[yesnault]

Hi all. Yes, we are aware of this pull-request. It's under discussion and we will rework in few weeks. Our goal is to not impact existing users and if we can avoid adding a flag to enable or not a feature, it should be better.
With this PR implementation of the check, the check is done when the file is read. But, with some templating variables, the check will probably failed even if the file is ok with the good values of variables. It's not so easy to do a good check with different use case that we already know, that's why removing the feature was better than trying to get something to work, but that ruled out some uses of the template engine.

[yesnault]

Ok. We discussed this issue again, we decided to rollback the current behavior which ignore errors in yml files. We don't want a flag to ignore or not: if some users want to run only a subset of yml files, they will have to filter the files list given to venom.
We will release the venom 0.28.0 with the current master, then removing the 'no-check' for the release 0.29.