-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check volume type before reducing from StorageDomain #185
Comments
aesteve-rh
added a commit
to aesteve-rh/vdsm
that referenced
this issue
May 18, 2022
There is not safety check before reducing a volume in the StorageDomain class. This could lead to wrong reductions in case of, e.g., raw or preallocated volumes. Use vol.can_reduce method before reducing the volume. Fixes: oVirt#185 Signed-off-by: Albert Esteve <aesteve@redhat.com>
aesteve-rh
added a commit
to aesteve-rh/vdsm
that referenced
this issue
May 18, 2022
There is not safety check before reducing a volume in the StorageDomain class. This could lead to wrong reductions in case of, e.g., raw or preallocated volumes. Use vol.can_reduce method before reducing the volume. Fixes: oVirt#185 Signed-off-by: Albert Esteve <aesteve@redhat.com>
aesteve-rh
added a commit
to aesteve-rh/vdsm
that referenced
this issue
May 18, 2022
There is not safety check before reducing a volume in the StorageDomain class. This could lead to wrong reductions in case of, e.g., raw or preallocated volumes. Use vol.can_reduce method before reducing the volume. Fixes: oVirt#185 Signed-off-by: Albert Esteve <aesteve@redhat.com>
aesteve-rh
added a commit
to aesteve-rh/vdsm
that referenced
this issue
May 18, 2022
There is not safety check before reducing a volume in the StorageDomain class. This could lead to wrong reductions in case of, e.g., raw or preallocated volumes. Use vol.can_reduce method before reducing the volume. Fixes: oVirt#185 Signed-off-by: Albert Esteve <aesteve@redhat.com>
nirs
pushed a commit
to aesteve-rh/vdsm
that referenced
this issue
May 18, 2022
There is not safety check before reducing a volume in the StorageDomain class. This could lead to wrong reductions in case of, e.g., raw or preallocated volumes. Use vol.can_reduce method before reducing the volume. Fixes: oVirt#185 Signed-off-by: Albert Esteve <aesteve@redhat.com>
nirs
pushed a commit
that referenced
this issue
May 18, 2022
There is not safety check before reducing a volume in the StorageDomain class. This could lead to wrong reductions in case of, e.g., raw or preallocated volumes. Use vol.can_reduce method before reducing the volume. Fixes: #185 Signed-off-by: Albert Esteve <aesteve@redhat.com>
erav
pushed a commit
to hbraha/vdsm
that referenced
this issue
Jun 21, 2022
There is not safety check before reducing a volume in the StorageDomain class. This could lead to wrong reductions in case of, e.g., raw or preallocated volumes. Use vol.can_reduce method before reducing the volume. Fixes: oVirt#185 Signed-off-by: Albert Esteve <aesteve@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
There is no safety check before reducing a volume in the
StorageDomain
class. This could lead to wrong reductions in case of, e.g.,raw
orpreallocated
volumes.StoragePool.reduceVolume()
is usingStorageDomain.reduceVolume()
, which is taking themetadata_lock
and then calling to the Volume.reduce method with the volumeoptimal_size
.Plan
vol.can_reduce()
method (which takes into account the type and the format of the volume) before reducing the volume in theStorageDomain
.This way, we avoid a potential wrong reduction and save the time of obtaining the optimal_size() in those cases.
The text was updated successfully, but these errors were encountered: