Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in context of PR #542

Closed
2 tasks
basejumpa opened this issue Sep 25, 2018 · 1 comment
Closed
2 tasks

Improvements in context of PR #542

basejumpa opened this issue Sep 25, 2018 · 1 comment

Comments

@basejumpa
Copy link

basejumpa commented Sep 25, 2018

Description

Below the repository's name there is the branch of the context shown. That's fine on code pages.

But being in context of a pull-request (PR), octotree in version 2.4.9 shows the base branch of the PR. That does not fit to the diffs shown.

Within a PR you deal with deltas between two or more commits.

  • Feature Request-1: Feature Request: In PR context, octotree shall not display base branch but the two references of the diff in the PR. So two branches or a short commit hash.
  • Feature Request-2: Octotree shall regard the commit which is selected on the PR's "Files changed" page.

Environment (if bug)

  • Octotree version: 2.4.9
  • Browser & version: Chrome, Version 69.0.3497.100 (Official Build) (64-bit)
  • OS & version: Windows 10
  • Screenshot, if any (drag an image here)

image

image

  • Console error log below this line:
    -none-
@basejumpa basejumpa changed the title In context of PR, show head-branch, not base branch Branch(es) shown in context of PR Sep 25, 2018
@basejumpa basejumpa changed the title Branch(es) shown in context of PR Improvements in context of PR Sep 25, 2018
stevennoto added a commit to stevennoto/octotree that referenced this issue Oct 5, 2019
@stevennoto
Copy link
Contributor

Hey @basejumpa, I know this is an older issue, but for Hacktoberfest I took a look and think I have fixed the branch display. See linked PR with screenshot.

I addressed your first feature request, to show both the head and base branches. I'm not sure about the second one, to somehow show reflect which files or commits are filtered in the PR view. In these cases, Octotree still shows the full PR file tree, so I think it's appropriate for it to keep showing just the base and head branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants