Remove extra || in SKIP formatting && bump k8 test binary to fix e2e issues found #4256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
martinkennelly
requested review from
trozet,
dcbw,
girishmg,
jcaamano and
tssurya
as code owners
✅ Deploy Preview for subtle-torrone-bb0c84 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Should bump the k8 test binary to a version that matches the k8 version in our go.mod but for now, just want to see if this commit fixes the test issues. |
K8 1.28.0 e2e test binary contains a programming error for dualstack "Granular Checks: Services Secondary IP Family" tests. See K8 commit: e7cfe85b9c1e760fb3537fe8feb5fb61c3a4aed2 for more details. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
martinkennelly
force-pushed
the
dualstack-gran-checks-e2e
branch
from
af495ca
to
54a40ac
Compare
tssurya
reviewed
Apr 5, 2024
| @@ -45,7 +45,7 @@ install_kind() { | |||
| } | |||
|
|
|||
| pushd $TMP_DIR | |||
| K8S_VERSION="v1.28.0" | |||
| K8S_VERSION="v1.28.6" | |||
There was a problem hiding this comment.
haha you are awesome martin!!! :) thanks for spending time on this!
tssurya
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix issue found in e2e tests in PR: #4253
Following tests were failing but should now be resolved:
](https://github.com/ovn-org/ovn-kubernetes/actions/runs/8551587549/job/23431934438?pr=4253)
More details in #4253 regarding the first commit.