-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link checker is temperamental and apparently deprecated #1990
Comments
Yeah! Looks like he's also created a new github action. |
Ok so do you want to try and upgrade it? |
Hi @ike, any update on this? |
Related to OWASP#1990
It would also be good to only include 5.0 in the link checker and not 4.0 because we don't change 4.0 any more but we do add translations so it makes a mess: |
Alright, I'll work on migrating the workflow to a proper replacement and running it for
The findings from https://github.com/OWASP/ASVS/actions/runs/10573577586/job/29345695930?pr=1973 look legit to me as they are 404. My understanding is they just irrelevant as |
Correct
Great! |
Just a small update: As #2035 has been merged please let me know if you notice something is broken or works not as expected. I'll keep an eye on the workflow too. The only part left to resolve this issue is addressing URL checker action deprecated status. I'm going to work on it this week. |
Thanks so much! |
The link checker seems to sometimes fail, even when it should not.
For example:
https://github.com/OWASP/ASVS/actions/runs/9854671316/job/27207915942
The link seems to work even through the link checker said it didn't.
Also, it says in the README that it is deprecated.
https://github.com/gaurav-nelson/github-action-markdown-link-check?tab=readme-ov-file
@ike do you think you could upgrade to the newer tool he suggests?
The text was updated successfully, but these errors were encountered: