Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task that exit with error should set the exit code #66

Closed
omerlh opened this issue Jun 22, 2017 · 2 comments · Fixed by #68
Closed

Task that exit with error should set the exit code #66

omerlh opened this issue Jun 22, 2017 · 2 comments · Fixed by #68

Comments

@omerlh
Copy link
Collaborator

omerlh commented Jun 22, 2017

Task should be able to report a fatal error by setting the exit code. Currently I tried Glue.error, but it only reports the error and not setting the exit code to 1. I think that if task encounter fatal error, it should be detectable by the CI tool and the build should fail.

@mkonda
Copy link
Collaborator

mkonda commented Jul 4, 2017

Interesting. So far we assume we will signal with the -z flag to send a signal if there are issues but I agree, if there is an error it should also fail.

Maybe we should add a fatal error level that exits immediately and sets that code. Would that fit what you are thinking?

@omerlh
Copy link
Collaborator Author

omerlh commented Jul 4, 2017

Yeah, that sounds good to me. I could add a PR for that in the next few days hopefully...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants