You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TableMeta.dataset should be a reference to DatasetMeta, but it's currently a cached copy that might be overwritten. This has caused confusion and we had to implement weird hacks to make it behave.
It's misused in several places if you search for metadata.dataset = (probably doing nothing as it gets overwritten when saving the dataset).
Instead of keeping a copy, we could make a read-only property out of it and even point it to the actual DatasetMeta object.
We can also consider DRYing dataset metadata that is saved in both index.json file and [table].meta.json files (and load dataset's metadata when loading the table).
The text was updated successfully, but these errors were encountered:
This has been fixed in ETL steps, but it's still a problem in core ETL. It has caused some nasty bugs in the past. I'm not going to reopen this now, but I might if I run into this again in the future.
TableMeta.dataset
should be a reference toDatasetMeta
, but it's currently a cached copy that might be overwritten. This has caused confusion and we had to implement weird hacks to make it behave.It's misused in several places if you search for
metadata.dataset =
(probably doing nothing as it gets overwritten when saving the dataset).Instead of keeping a copy, we could make a read-only property out of it and even point it to the actual
DatasetMeta
object.We can also consider DRYing dataset metadata that is saved in both
index.json
file and[table].meta.json
files (and load dataset's metadata when loading the table).The text was updated successfully, but these errors were encountered: