Split vst functions into fit & transform #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO to be ready for review:
|
jeandut
reviewed
Oct 19, 2023
hippolyteheuberger
requested review from
BorisMuzellec,
maikia and
arthurPignetOwkin
as code owners
|
@SimonGrouard I have added the different tests :) |
* CI: add ruff * ci: fix ruff line length argument * ci: update ruff configuration, remove flake8 and isort * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * CI: integrate isort options to ruff, remove nbqa * CI: fix force-single-line typo * CI: add ruff exceptions for sphinx gallery examples * chore: fix linting * chore: linting * ci: add exception to linting for sphinx examples * docs: renove extra period in sphinx examples --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
BorisMuzellec
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
LGTM, thanks @hippolyteheuberger @SimonGrouard ! I'm finally merging this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR implement?
https://docs.google.com/presentation/d/1IyFTz4KdavaljiFbnCQitfE4N-9tdKZgWFjo8WOseKc/edit#slide=id.g29024929474_0_905
Additionally mutualized the synthetic data fixtures between the different tests in test_pydeseq2.py, let me know if this is not desirable.