Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWLTools-Solr cleanup #181

Open
1 of 6 tasks
cmungall opened this issue Mar 30, 2017 · 2 comments
Open
1 of 6 tasks

OWLTools-Solr cleanup #181

cmungall opened this issue Mar 30, 2017 · 2 comments

Comments

@cmungall
Copy link
Member

cmungall commented Mar 30, 2017

Not clear how much to invest if we want to instead switch to loading from blazegraph, or reuse monarch solr-loader.

  • test suite
    • investigate best strategy for testing Flexdocs, cc @kltm
    • some tests such as AllOntologyLoaderIntegrationRunner fail and are skipped. Why?
    • do more thorough testing of logic
    • add tests for panther
  • populate redundancy field
  • why is there two PANTHER classes? PANTHERGeneralSolrDocumentLoader and PANTHERSolrDocumentLoader
    • now understood. one populates documents following the general schema
@kltm
Copy link
Member

kltm commented Mar 30, 2017

Depending on what you are doing, I suspect the direct testing of flexdocs accomplishes little.

I unfortunately have little memory of AllOntologyLoaderIntegrationRunner--I suspect that this is not my code originally--but I can go through that at some point ans untangle what is going on.

which two panther classes are you referring to?

@cmungall
Copy link
Member Author

only these ones are executed:

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.648 sec - in owltools.solrj.BioentityClosureTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.772 sec - in owltools.solrj.GafSolrDocumentLoaderTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.05 sec - in owltools.solrj.TransitivityGraphTest
  • AllOntologyLoaderIntegrationRunner.java, fails - does not find catalog
  • FullTaxonIntegrationRunner.java fails - does not find a taxon file
  • GafSolrDocumentLoaderIntegrationRunner.java - does not find catalog
  • GoLoaderIntegrationRunner.java fails - no catalog
  • OntologyAndGafLoaderIntegrationRunner.java fails - no catalog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants